emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Fraga, Eric" <e.fraga@ucl.ac.uk>
To: reza <reza@housseini.me>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] org-beamer :BEAMER_ACT: ignored on columns
Date: Wed, 5 Oct 2022 08:19:44 +0000	[thread overview]
Message-ID: <87k05esmw0.fsf@ucl.ac.uk> (raw)
In-Reply-To: <01020183a6ddf08d-3a0a1b66-f39a-47ba-8222-d6db2cbf8992-000000@eu-west-1.amazonses.com> (reza@housseini.me's message of "Wed, 5 Oct 2022 06:38:26 +0000")

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Wednesday,  5 Oct 2022 at 06:38, reza wrote:
> But the overlay specification is missing on the second column and I
> guess this is a bug?

Maybe a bug or more simply a missing feature.  On line 552 of
ox-beamer.el, we add options but there is no equivalent for adding
actions to the column definition.

The attached patch adds action processing but I've only tested it
minimally (busy with teaching unfortunately).

-- 
: Eric S Fraga, with org release_9.5.5-851-ge9781f in Emacs 29.0.50

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-ox-beamer.el-Add-BEAMER_ACT-to-column-definitio.patch --]
[-- Type: text/x-diff; name="0001-lisp-ox-beamer.el-Add-BEAMER_ACT-to-column-definitio.patch", Size: 1741 bytes --]

From 6668760b3be48610dddb03f20c5291760c11b8bf Mon Sep 17 00:00:00 2001
From: Eric S Fraga <e.fraga@ucl.ac.uk>
Date: Wed, 5 Oct 2022 09:15:05 +0100
Subject: [PATCH] lisp/ox-beamer.el: Add BEAMER_ACT to column definition

* ox-beamer.el (org-beamer--format-block): Process BEAMER_ACT if given
for column block.
---
 lisp/ox-beamer.el | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/lisp/ox-beamer.el b/lisp/ox-beamer.el
index 51684448d..1d84aae6e 100644
--- a/lisp/ox-beamer.el
+++ b/lisp/ox-beamer.el
@@ -512,6 +512,11 @@ used as a communication channel."
 	 (options (if raw-options
 		      (org-beamer--normalize-argument raw-options 'option)
 		    ""))
+         ;; also process actions
+	 (raw-actions (org-element-property :BEAMER_ACT headline))
+	 (actions (if raw-actions
+	              (org-beamer--normalize-argument raw-actions 'action)
+	            ""))
 	 ;; Start a "columns" environment when explicitly requested or
 	 ;; when there is no previous headline or the previous
 	 ;; headline do not have a BEAMER_column property.
@@ -546,10 +551,11 @@ used as a communication channel."
        (if (not (equal environment "columns")) "\\begin{columns}\n"
 	 (format "\\begin{columns}%s\n" options)))
      (when column-width
-       (format "\\begin{column}%s{%s}\n"
+       (format "\\begin{column}%s%s{%s}\n"
 	       ;; One can specify placement for column only when
 	       ;; HEADLINE stands for a column on its own.
 	       (if (equal environment "column") options "")
+	       (if (equal environment "column") actions "")
 	       (format "%s\\columnwidth" column-width)))
      ;; Block's opening string.
      (when (nth 2 env-format)
-- 
2.30.2


  reply	other threads:[~2022-10-05  8:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <41d13343-d278-2474-ba8f-88d24621ab30@housseini.me>
2022-10-05  6:38 ` [BUG] org-beamer :BEAMER_ACT: ignored on columns reza
2022-10-05  8:19   ` Fraga, Eric [this message]
2022-10-06  3:06     ` Ihor Radchenko
2022-10-06  8:01       ` Fraga, Eric
2022-10-07 13:16         ` Fraga, Eric
2022-10-08  6:10           ` Ihor Radchenko
2022-10-10  7:38             ` Fraga, Eric
2022-10-12  6:00               ` Ihor Radchenko
2022-10-12  7:42                 ` Fraga, Eric
2022-10-13  2:39                   ` Ihor Radchenko
2022-10-13  8:59                     ` Fraga, Eric
2022-11-14  5:48                       ` Ihor Radchenko
2024-01-31 14:29                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k05esmw0.fsf@ucl.ac.uk \
    --to=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    --cc=reza@housseini.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).