From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gALsBIOSbGOhagEAbAwnHQ (envelope-from ) for ; Thu, 10 Nov 2022 06:56:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KKoKBYOSbGPQUwAA9RJhRA (envelope-from ) for ; Thu, 10 Nov 2022 06:56:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0CA42264F for ; Thu, 10 Nov 2022 06:56:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot0Ww-0001lJ-Gd; Thu, 10 Nov 2022 00:55:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot0Wu-0001kw-V6 for emacs-orgmode@gnu.org; Thu, 10 Nov 2022 00:55:12 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot0Ws-0004q9-Gu for emacs-orgmode@gnu.org; Thu, 10 Nov 2022 00:55:12 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2EDED240026 for ; Thu, 10 Nov 2022 06:55:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668059708; bh=cOO4Cw/it+yheDi64cs+X7+MeYT697LkirBK+ckuKUI=; h=From:To:Cc:Subject:Date:From; b=R6rQ8eNEj3wCDhTEBb1y8NjTdkjgqJ1GbV1N1itnL1iGAjdw1Z/PQYSFEAAPy8u64 YVp8IlbkDPxVSNZcNoLtFsoiGm3cyM1mT0ZUM5JrOd/pVlK1OcQOmvBCh6UTQ9vybU 6smYE/7WSJ4qQRAhG5S+9sNF8/0qa0jjeq3hsOtpdekFstwNc2U30GZzRt64JNg7Vp i74G1pHuAK81eNsG0fD3TPWx+5RL+wgZOsOFqASFy6Oz81FfOkTcQ4AdwdUhmPVxsa fLnsm+AmjN5xux6VCX/awxKPUl8pEmWTFStnb7PFpaE9H2p8a3Rz4J65zea3/sk/4g WkpEeL9fFUwYw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N79zG5XVMz6tmK; Thu, 10 Nov 2022 06:55:06 +0100 (CET) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Re: [BUG][Security] begin_src :var evaluated before the prompt to confirm execution In-Reply-To: <87ilk4myev.fsf@localhost> References: <87ilk4myev.fsf@localhost> Date: Thu, 10 Nov 2022 05:55:46 +0000 Message-ID: <87k043jqu5.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668059775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JkAeCOh0/+Q52pP114TA8MOLPwV0yQKw/ukxcXTrw8Y=; b=JfyEbQSqv5cCr+xHg6h/ULYVWFmxsjFiIfLcdWZ0/UAyRLWWGRKGdQBeYx5KKp9ptbfVlu E8MP6Ap1Zl13MjcJnbS1ip1osMETq0crwO8Xzi3EKbyPgKO9mYaerPzgA/mxpUbA1LeYps t08++s/CcP17zV3eWPR9mraB4p9rcDWkwrM/i274C/7kBDrbV/x9q//iOH9kFWN8UBGGrY sMrMPIPD19LkROrrwpyexWQ2s7TPp6w7rIZUhCIXB+RWSrAn0B57dv1knrOdyOmFCCHySz rhLg4RZtdbC3m/0g0TyxDdI7n1sfRl0YSsiyIv3GLFn3srfH6Ph3vBFPUrwzYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668059775; a=rsa-sha256; cv=none; b=Ha64cHz1BZ7oq9sNU6qKIUP2sobCu4hp9MGa1iOtDgnaexKB93/9Af2h42/mEgun4tjZBz P933PVCVCXXKVITADoO3wBv0Ue9YrY8NRMIl3Kl3aSqHjl1VpUswSJaofRZbl31GVO7+x9 d9sKKBRnHlWm/sIXzvc+cdtLbDx+T6OlK/Ls+ibwFCLacgeNI06Z35IYpmPtVvRAVOfkI9 Kz2duTuZPqzTjCR5/XhIJQJEsQ5dcAZ6YkhMzOSrPrbxv6SZQP8q4VXoqz2E9GgU/eKtLW El6J4TsG3Du7Jz1MGQzCNfm+Bs8PkS5/eyK28LW4PqUzm5u3tzZ3hFz1PcnWzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R6rQ8eNE; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.22 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R6rQ8eNE; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E0CA42264F X-Spam-Score: -7.22 X-Migadu-Scanner: scn0.migadu.com X-TUID: EaONr0TctEuI Ihor Radchenko writes: > See the attached tentative patch. > I tried to balance between annoying users with query and not evaluating > unsafe code: '-quoted lists and symbols are still evaluated without > prompt. Fixed. Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=10e857d42859a55b23cd4206ffce3ebd0f678583 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at