From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +KdAH2L5lWMYewAAbAwnHQ (envelope-from ) for ; Sun, 11 Dec 2022 16:38:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kF5cHmL5lWNnRwAAG6o9tA (envelope-from ) for ; Sun, 11 Dec 2022 16:38:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F610274A9 for ; Sun, 11 Dec 2022 16:38:09 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4OIl-0003bH-CB; Sun, 11 Dec 2022 10:31:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4OIj-0003Us-Lp for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 10:31:37 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4OIi-0003v6-1I for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 10:31:37 -0500 Received: by mail-ed1-x52a.google.com with SMTP id m19so9569580edj.8 for ; Sun, 11 Dec 2022 07:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z/vz99d0jwNPKhO23P8+GHmK0oVQD3pSqKZaj72eFKc=; b=mV1o8qDNPHxf+D6vGVJZ9oQcTwHdXGacoqOADtKhHe7Yj8TY6JGmjU4TmF9aWuC+DE 6rjscWTSCQZKS0F4oB63oDhbp+WxTCbgqdVT/42UcHPMC+9nQFVyk6keMzEDtJVJI0aG PQ8fKSkMiXv/sW8YSB0rgCqkWPKQ2p5sDPp+aumHVe0HpDelK0+OrZmBc9pKg1pguOhj cHbm42dgM5R202UZ9SicO/M/bryKUXrHTrlgy3dm/e/ZivqLRnGjjwvnDu77OlgwSPkT oJS+i7xhL8ZTcLjV6IIZ8vHN2rAaQTPAoFuqNa/7l5sDQ5TXlDyyGotbKZ04jIQpJz9k BTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z/vz99d0jwNPKhO23P8+GHmK0oVQD3pSqKZaj72eFKc=; b=IuhlmWvHFKy/PH7053B1JtX8XVzukdKZEVLZlhbv3usFKSuSLhJ1QSaxxlwddf9nut QuD6HzxHYZtnzkClNYF1bidd/L/jepJq3ErMmutUhgBi6kC9zzhcH33LB7A9rgMUWAY9 KQJMU0JO7zOaLHyZXksRZfQldHBQJBw9PSi25eFLf7vBIc6OhLVDZkEcWIWNuovvuvbW UL4SvBXaU71nIAjr0OU3SxzJ1uAHoAp2xXkPr2O5w8pFZc8X888KimKxV0EIht8NnZhq SOJBy/NttA0qCOTLlqFsvaCqlrRiFmh2wnXBFRIOrCqPebPRJ6RlBGtzaQKEFK0hSDzA rZGQ== X-Gm-Message-State: ANoB5plT2QfmsLdTm9BsZvbX0C8zQfVi7ARa/oDiknoMoh4z7nJ3Ayb3 f1WqpxN6tLfO+IJw8rAWPXk= X-Google-Smtp-Source: AA0mqf4LEG7DnClXFL55m2RbzPI+3UvwDFwncrXEmrWrh6BEhXNG7dAKP+EOBBn4x0Nb7mABkVn43A== X-Received: by 2002:a05:6402:4d6:b0:45c:835c:1ecf with SMTP id n22-20020a05640204d600b0045c835c1ecfmr11332929edw.29.1670772693584; Sun, 11 Dec 2022 07:31:33 -0800 (PST) Received: from flexignu ([2a02:908:1d5:3c20:ffc4:1314:9183:44d]) by smtp.gmail.com with ESMTPSA id v18-20020aa7cd52000000b0046ae912ff36sm2805910edw.84.2022.12.11.07.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Dec 2022 07:31:33 -0800 (PST) From: Jeremie Juste To: Ihor Radchenko Cc: Greg Minshall , Johan =?utf-8?Q?Tol=C3=B6?= , emacs-orgmode@gnu.org, "Berry, Charles" Subject: Re: [BUG] ob-R.el: extra empty data.frame columns generated from plain lists after recent change [9.6 (release_9.6-3-ga4d38e @ /usr/share/emacs/30.0.50/lisp/org/)] References: <87wn77mdvk.fsf@toloe.se> <766358.1670208594@archlinux> <87wn74xjv7.fsf@gmail.com> <87bkofh0ir.fsf@localhost> <87sfhqudks.fsf@gmail.com> <87edtantzq.fsf@localhost> Date: Sun, 11 Dec 2022 16:31:32 +0100 In-Reply-To: <87edtantzq.fsf@localhost> (Ihor Radchenko's message of "Thu, 08 Dec 2022 09:07:53 +0000") Message-ID: <87k02yq7mz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=jeremiejuste@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670773090; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Z/vz99d0jwNPKhO23P8+GHmK0oVQD3pSqKZaj72eFKc=; b=DHNtjynsL8hSlI60fVDA1ZZH+qcJIUQreR9LRy3/rmFroaOYLGmYrr2itV0uI4Dij/ZRPF PF/OPAi0OWWfx8hn2KzfcWKoOgPgGtljJH5I0fS8Rat5KoCycszAous2ZqTfFHIr48Bnuu 2vFu4Psam2WCs69sgcfdrJQ0dA6evo4+P4N0xLZbGMSFqh47yrCRQV+i2YoVdMoqH/2rd/ Mwafhz1aTeXWmt0cmL9cqvdkJsQxn6el3YJzGQnyIQRBRrNPis2f+JLLEMupd8tUN/dCYI vGbUuBXFoSpoyLzSB3ndxfslYSRdKBhZ09cln6QIq0UzhuVNI8VJh+P0px1NfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mV1o8qDN; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670773090; a=rsa-sha256; cv=none; b=RiKIoDpOuk4f1GUGs52GdofRjXnaMZ+pcM2RTIRktZ00mR9wvJjzGrnLPQZBNJqJLGkrri Zw/8a6Bk/3cwa2fQ6XfOIYKbD3eevhw1YW6qzpJbP1Zxesg+Ol/3ktCvwoCgBuEq+pgRwA vISBjVc2m56+f7C9S5KqZcWM+O2LLtlMGMw/4+64oQb4Z+iwtZGHLfldpxBU3yr0jij4h2 fNLPubZBxUnaPWXOTLCj+4dFE1ePHVXmY1jmrD2+Nzur+Ex+YKMiiv9Cc5Nps/aFe2oDde CcAO/7YiwA8wmx6nn2mkOU16vOh4XVd4s1tuKKtPSYV3R+vcp0YzzngrlQctXA== X-Migadu-Spam-Score: -7.39 X-Spam-Score: -7.39 X-Migadu-Queue-Id: 0F610274A9 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mV1o8qDN; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: JjPXpLTAFWEl Hello Ihor On Thursday, 8 Dec 2022 at 09:07, Ihor Radchenko wrote: > I am not sure if I like the approach you used in the commit. > > - (unless (listp (car value)) (setq value (list value))) > + (unless (listp (car value)) (setq value (mapcar 'list value))) > > In the above, you are transforming (val1 val2 val3 ...) list into > ((val1) (val2) (val3) ...). > > Does it make sense from the point of view of R code? > AFAIU, the current ob-R implementation converts lists into R tables, > which is not accurate? Would it make sense to convert Elisp lists into R > lists directly? Many thanks for the feedback. At this point I don't know. On one hand you are right on the other, this option is backward compatible, and the user can always create an interface in R to suit his need. If there are more complaints about that in the future, I'll reconsider. Best regards, Jeremie