From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IHLnF/tcJ2RdCQAASxT56A (envelope-from ) for ; Sat, 01 Apr 2023 00:21:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gD7tF/tcJ2SkegEA9RJhRA (envelope-from ) for ; Sat, 01 Apr 2023 00:21:47 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C5892DBDC for ; Sat, 1 Apr 2023 00:21:46 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piN70-0003Hh-L1; Fri, 31 Mar 2023 18:20:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piN6z-0003HN-Di for emacs-orgmode@gnu.org; Fri, 31 Mar 2023 18:20:45 -0400 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piN6x-000834-8u for emacs-orgmode@gnu.org; Fri, 31 Mar 2023 18:20:44 -0400 Received: by mail-pj1-x102a.google.com with SMTP id fy10-20020a17090b020a00b0023b4bcf0727so24909462pjb.0 for ; Fri, 31 Mar 2023 15:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680301241; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=zBAsTM6vVwcw3m1J9lXWQAKSd/1X50qbz3NHsrDXIHU=; b=C9FIDOp6zYSFB2Vta/yC9wd6CzfCGo6pKe1aG8YU2sXzcuNtZE5fPthTwSNV31zp30 uQo1r768gCDT1WjhrwKM6p5qAHcuFshs8UOuL3GUZKQ1XtXuv+RrMoylmwXWYkq1OjhN D9DL4Ps510Txtm3iJBev0yzMr3oLQAP3pM39L+mqNkHqxxNRkl+2J+sU1ArWjW0HaEdJ IfG5P4qaDFE/HfLwTgIimpzqHQATEKaSmbKlPi85hT9W0GthVyFkrWMWmWxYZl8bhJQx krNFzsjQrrx+OURjiX51DQ1ywOX2jkUfuw43hPwhx20C8tLydWwjgWUd4Q/QuWw/jJzu omjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680301241; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zBAsTM6vVwcw3m1J9lXWQAKSd/1X50qbz3NHsrDXIHU=; b=fnxGkY+rvNfAydqUQ7JCO2IXEkRCAlFH1taPXyAVJRjqD7jkiTy/8cXGfdBVUGc1bK mr6Jgw/U/nbcooXVpADYcHsHyac1PskNVMbu7ewoD17PfSn1sVVWHB+NWyI4qLDxD43F 3M1WIUY+2MDlTQfnZVk6Jr7w8+bj+KJD7zDhX0Hwyz/4zTY8q9gsYvWpBANDtOhAY2Mp 6vilsA/L+jQQYm9FvtMhb8Z7XHT/3h3+ah3rCyjbDwLkgZ4z+I96e3zFXQI1NBB21mq/ jnfTA1Zgl7/jSCjW/M//3gbDhRt5bLCiDaO3f2hbyr/aoZg6CW05ahFNV/irDkmRMO1x 6RwA== X-Gm-Message-State: AAQBX9eBxN1TIraObPtklvE3Df1jFPN93LZNl+pytOb7VXrt9aHzJZrz EF5t8ihOg7G9OD+WwlLKZbJWtHND1YY= X-Google-Smtp-Source: AKy350YSB40moaB16zgmYgnZC22f1lP1l1ltgIuLKJ+9qcEgX6enIDZrHwnwwDz8vMgPkBJqwIkXwQ== X-Received: by 2002:a17:902:d091:b0:1a1:dd2a:fe6c with SMTP id v17-20020a170902d09100b001a1dd2afe6cmr22669013plv.53.1680301241141; Fri, 31 Mar 2023 15:20:41 -0700 (PDT) Received: from localhost (157-131-78-143.fiber.dynamic.sonic.net. [157.131.78.143]) by smtp.gmail.com with ESMTPSA id jn22-20020a170903051600b0019a95baaaa6sm2005837plb.222.2023.03.31.15.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 15:20:40 -0700 (PDT) From: Jack Kamm To: Ihor Radchenko Cc: emacs-orgmode@gnu.org, mail@nicolasgoaziou.fr Subject: Re: [RFC] ox-icalendar: Unscheduled tasks & repeating tasks In-Reply-To: <87fs9kajx7.fsf@localhost> References: <874jq75okg.fsf@gmail.com> <87o7oetneo.fsf@localhost> <87r0t5jwgy.fsf@gmail.com> <87v8ih9ihw.fsf@localhost> <87o7o8kji5.fsf@gmail.com> <87fs9kajx7.fsf@localhost> Date: Fri, 31 Mar 2023 15:20:39 -0700 Message-ID: <87jzywk1fs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=jackkamm@gmail.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680301307; a=rsa-sha256; cv=none; b=FvYkrDH9EJm4v8KvpxsjDsXk0OylIseQebPQcLmZnacXzola6vDe3zAT3W4edE9oUNqTgk EGR8tdPOGdYjNDCJNQ1uOmL7+1M1Qzl/+nq1MIGJ70Df7oHtnr4Rk7U3FCz7ah8kmeYgON vR3XMb8t4Ykezo7s7krjRF3AxSIV6V0CrVWYF64fDTH3gX02rwBdATygR2UsM+1N0fjBFg PIhCQeClbbKg0Ea1Pflmrtoo5pl0DscPPuWr2o02tY3XdH/taZSPLstco5ydmAGZpoHLvD /6bzf3yhaXSj0KjNlAlpGkxL7GO6y8mYnBnQYojF8pd8A6yOda2ZqCHE3BR4Kw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C9FIDOp6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680301307; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zBAsTM6vVwcw3m1J9lXWQAKSd/1X50qbz3NHsrDXIHU=; b=V9VWNFYgnt6REKpgnGZyFCWpCQ8sVj1bwNym+BPdPMc8+Awbw0gX6//9x9GjATH3WzHBeh E9j1IULEOxeTuBpDYuuLd4WBdovYOtXYWG/JtTClzDoxx1TUZj45J9kCplydFQiSuz/CKJ CR01X/jG6kyv6AqWYC5qo5XW2lF3wD2rdirnYFZNu7gbxgo9DoEmzxi8DHkiQs0fioe7VH HN6sPahiavICRhijQ0hfenKn4OlEy99h6YoTxT4Junw1Y/SqGZiCqDkObMAa8VhwiusmCP /cjsNdU1RSc2WhejYPT+yvPTiKaSAgl1iImS0+HTaYrMefrhqFkw+gzaQk9jGw== X-Migadu-Spam-Score: -6.46 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C9FIDOp6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -6.46 X-Migadu-Queue-Id: 0C5892DBDC X-TUID: 19V3KeivpGry Ihor Radchenko writes: > I now only have one minor concern about `org-icalendar-fold-string' when > the original buffer contains DOS line endings. May they mess things up > producing \r\r\n? There are 2 issues here: what does `org-icalendar-fold-string' do when string already contains \r, and what does `org-export-to-file' do when `org-export-coding-system' or `buffer-file-coding-system' is dos-like. In both cases, the patch doesn't change the existing behavior -- which is to produce \r\r\n. For issue 1, what `org-icalendar-fold-string' does when string already contains \r\n, you can see that it produces \r\r\n as follows: emacs -Q -l ox-icalendar M-: (org-icalendar-fold-string (org-icalendar-fold-string "Line1\nLine2")) This is why the patch removes the calls to `org-icalendar-fold-string' in `org-icalendar--vevent' and `org-icalendar--vtodo' -- otherwise we would add \r multiple times to the same string. To change this behavior of `org-icalendar-fold-string', we could modify the patch to do: (defun org-icalendar-fold-string (s) "Fold string S according to RFC 5545." (replace-regexp-in-string - "\n" "\r\n" + "\r*\n" "\r\n" which would strip out any extra \r at end of line. Another alternative would be to use "\r?\n" instead of "\r*\n". For the second issue -- when `org-export-coding-system' is dos (or similar), the file created by `org-export-to-file' will contain \r\r\n. This was already the pre-existing behavior, but note the patch does cause a minor change here: before the patch just the main body will have \r\r\n, but after the patch, the preamble will also have it.