emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Bastien <bzg@gnu.org>
Cc: Karl Fogel <kfogel@red-bean.com>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix warning about using `eq' to compare strings.
Date: Wed, 01 Nov 2023 09:28:26 +0000	[thread overview]
Message-ID: <87jzr1ddqd.fsf@localhost> (raw)
In-Reply-To: <8734xphlyv.fsf@gnu.org>

Bastien <bzg@gnu.org> writes:

>> Unfortunately, fixing this warning breaks org-table logic and tests.
>> See previous discussion in
>> https://list.orgmode.org/orgmode/20230827214320.46754-1-salutis@me.com/
>
> Ouch. Reverted.

I added a FIXME explaining the issue to make the problem more clear. I
think this is the third attempted fix of this warning on the list :)

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1ef9e144a

Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-11-01  9:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 16:08 [PATCH] Fix warning about using `eq' to compare strings Karl Fogel
2023-10-31 20:40 ` Bastien
2023-11-01  9:11   ` Ihor Radchenko
2023-11-01  9:16     ` Bastien
2023-11-01  9:28       ` Ihor Radchenko [this message]
2023-11-01 10:00         ` Bastien Guerry
2023-11-01 16:29     ` Karl Fogel
2023-11-01 17:59       ` tomas
2023-11-02  8:14       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzr1ddqd.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kfogel@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).