emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Importing "quoted" strings in `org-babel-import-elisp-from-file' (was: [BUG] ob-shell: results missing leading quotes)
Date: Wed, 01 May 2024 12:19:35 +0000	[thread overview]
Message-ID: <87jzkdenc8.fsf@localhost> (raw)
In-Reply-To: <v0t6lb$1505$1@ciao.gmane.io>

Max Nikulin <manikulin@gmail.com> writes:

> On 29/04/2024 18:58, Ihor Radchenko wrote:
>> 
>> The nested "..." are stripped on purpose via `org-babel-string-read'.
>> Although this function dates back to R output processing and I do not
>> fully understand why stripping nested quotes is useful for all possible
>> babel backends. But that's a completely different story.
>
> I would say heuristics is quite fragile
>
> #+begin_src elisp :results verbatim
>    (org-babel-string-read "\"1 2\" 3 \"4 5\"")
> #+end_src
>
> #+RESULTS:
> : "1 2\" 3 \"4 5"
>
> Leading and trailing quote characters are not stripped in the case of
>
> #+begin_src elisp :results verbatim
>    (org-babel-read "\"1 2\" 3 \"4 5\"" t)
> #+end_src

Let's zoom out a bit.

`org-babel-string-read' is used exclusively by `org-babel-import-elisp-from-file'

Its effect is making the following tables look same for Org babel:

| 1 | 2 |
| 1 | 2 |

| "1" | "2" |
|  1  |  2  |

I cannot find justification - this behavior has been introduced in ob-R
from the very beginning (over 15 years ago) and then ported to ob-core.

IMHO, the current behavior is not correct. Moreover, it is unexpected.

Consider

#+begin_src C :results output table :includes <stdio.h>
printf("1 2\n\"1\" \"2\"");
#+end_src

#+RESULTS[30c03a8e3f8a71e03d7892e6817cb45713bec424]:
| 1 | 2 |
| 1 | 2 |

Why are the quotes dropped?

And replacing the call to org-babel-string-read with org-babel-read does not
break any tests...

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-05-01 12:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 13:15 [BUG] ob-shell: results missing leading quotes Matt
2024-04-29 11:58 ` Ihor Radchenko
2024-05-01 10:48   ` Max Nikulin
2024-05-01 12:19     ` Ihor Radchenko [this message]
2024-05-02 17:56       ` Importing "quoted" strings in `org-babel-import-elisp-from-file' Max Nikulin
2024-05-03 12:06         ` Ihor Radchenko
2024-05-04  7:53           ` Max Nikulin
2024-05-04  8:03             ` Ihor Radchenko
2024-05-04 11:17               ` Max Nikulin
2024-05-04 11:51                 ` Ihor Radchenko
2024-05-04 14:55                   ` Max Nikulin
2024-05-04 19:34                     ` Ihor Radchenko
2024-05-04 15:58                   ` Max Nikulin
2024-05-04 19:35                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzkdenc8.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).