From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4OgnHhoxGWdt7wAAqHPOHw:P1 (envelope-from ) for ; Wed, 23 Oct 2024 17:23:38 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4OgnHhoxGWdt7wAAqHPOHw (envelope-from ) for ; Wed, 23 Oct 2024 19:23:38 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BBUCGD69; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729704218; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0iz464K8ISUNaonXdEctEGZ7IpMHeRyi0E90ZgWQs3s=; b=KLmF4v19Twcweh+ffDYAVxr3jKoDvdp0Y8c02z0v8kBOlbiim7QUxKJSvUcE66muVNOu7K Y3s+XZEUCM4/9CuYD2gIv5n/9hcDoQFXNCQ55s/3hncMd8Ts9P1Tg/RrCKX88bkMQ2fx0u jgAL0fRZQ2eBURBH3BAxgNj+KEgUZI2Ujvvpty54B3Yw7gj4PmAVCnIa3hFKRLtS1cwmhl k8rKGc5jT67hczLUkquOdrMR7MjM87piDpcRiVYMxp005A3lBW+hJoCN2zl1ya4i0nKvNf UfoeN1QIwR2+6BFs80qoVOwUPgNlNYlQMPgG7gdnsmAmKIfX4mMHZKDrpCfnhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729704218; a=rsa-sha256; cv=none; b=V9h2yVYlw9lED+mo70zJWHA5fjtcv9RNHJnv5T+kGXkrA4R5eoaJI2qIZPztMV4P8aJO5C RUBGuwttruiSYLdKIkzLzD39bJZS/iWW18GJXcrB4Xo4TzGcoJDuDZwr+FPB2tyjnCsxpt GW/xrB/TqfcL2jRW5bw4AaGw7OwUAKeHjDKqJ5tf8m3AosOg58+UPUhPT9rAeyaQ5AXm2W tEzJOoyUjpSwhCLuV2gOmdW6XXxPkbA7tHJ8X7PoJCWg7eNo7K0iXO3jAsxB/ckW2EnTT4 QwtMNVMKTjMBZ1x8I9aBVQ+98ux+veCqpoi8FiI0LASMPe+idqWwSG+/Fku9uQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=BBUCGD69; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C5F2657856 for ; Wed, 23 Oct 2024 19:23:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3f4D-0006Y7-Bn; Wed, 23 Oct 2024 13:22:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3f45-0006Xd-Vg for emacs-orgmode@gnu.org; Wed, 23 Oct 2024 13:22:34 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3f42-0006KG-Kz for emacs-orgmode@gnu.org; Wed, 23 Oct 2024 13:22:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D8625240027 for ; Wed, 23 Oct 2024 19:22:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1729704142; bh=cr2KFj99Y+5CPe+ASH6OrNY40JOoQK8FxKni3TzRJ+E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=BBUCGD69d+z4m3yJKO1iaXnCyrIUEwhGqLszj6gtfaH5c7IBIQDU7G40bJta1TK4q t00m8V1HWbNt8SclddwOWsmdqjM1OMnlcuU32NTm1CBdiHnfd0DiaPXdvZ2GQ3vdTp lFc6/yJqjqUlGiNlNqfbjbmLnzc2NrLMkR+2GTLmTL59gGnKnLSzrKa+WOOvO9DuPS Q7VFs9hjBul133P30cIoGADnIkwb0jvmuIwBRDVJqzvfVduv4r/UuDwWjxUMUZOSLi fSqeQ61iagXioOSqXyVTXMHnX4pglJzL38azRggPDRTIQlzBnqGMsmnIjRJvc3ydQE fAI7zPXxZQFVg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XYbTB2rkBz6twJ; Wed, 23 Oct 2024 19:22:22 +0200 (CEST) From: Ihor Radchenko To: Jack Kamm Cc: emacs-orgmode@gnu.org, jeremiejuste@gmail.com Subject: Re: [PATCH] ob-comint,R,python: Options for more robust non-async session output In-Reply-To: <878qui3t7b.fsf@gmail.com> References: <87h6993y6q.fsf@gmail.com> <87v7xowod1.fsf@localhost> <878qui3t7b.fsf@gmail.com> Date: Wed, 23 Oct 2024 17:24:08 +0000 Message-ID: <87jzdyvikn.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.40 X-Spam-Score: -4.40 X-Migadu-Queue-Id: C5F2657856 X-Migadu-Scanner: mx13.migadu.com X-TUID: N/gdB2wftL7t Jack Kamm writes: > I've reattached the patch with this option removed, and also rebased > onto latest main. Thanks! I think that we need to do the same things as with your `org-babel-comint-async-register' patch: (1) ORG-NEWS; (2) possibly use more descriptive values. > - ;; Filter out prompts. > - (org-babel-comint--prompt-filter string-buffer))))) > + (if ,no-cleanup-prompt > + (save-match-data > + (string-match (regexp-quote ,eoe-indicator) string-buffer) > + (org-babel-chomp (substring string-buffer 0 (match-beginning 0)))) > + (org-babel-comint--prompt-filter string-buffer)))))) May you please explain this additional filtering of eoe-indicator here? Why did it become necessary and why you did not change anything when NO-CLEANUP-PROMPT is nil - `org-babel-comint--prompt-filter' does nothing about eoe-endicator. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at