Re: [PATCH] ob-comint,R,python: Options for more robust non-async session output

[Ihor Radchenko <yantar92@posteo.net>]

Jack Kamm <jackkamm@gmail.com> writes:

> I've reattached the patch with this option removed, and also rebased
> onto latest main.

Thanks!
I think that we need to do the same things as with your
`org-babel-comint-async-register' patch: (1) ORG-NEWS; (2) possibly use
more descriptive values.

> -         ;; Filter out prompts.
> -         (org-babel-comint--prompt-filter string-buffer)))))
> +         (if ,no-cleanup-prompt
> +             (save-match-data
> +               (string-match (regexp-quote ,eoe-indicator) string-buffer)
> +               (org-babel-chomp (substring string-buffer 0 (match-beginning 0))))
> +           (org-babel-comint--prompt-filter string-buffer))))))

May you please explain this additional filtering of eoe-indicator here?
Why did it become necessary and why you did not change anything when
NO-CLEANUP-PROMPT is nil - `org-babel-comint--prompt-filter' does
nothing about eoe-endicator.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>