emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Eric Schulte <schulte.eric@gmail.com>
Cc: "Sébastien Vauban" <wxhgmqzgwmuf@spammotel.com>, emacs-orgmode@gnu.org
Subject: Re: Re: Bug: #+ATTR_LaTeX broken in LaTeX export [6.36trans (release_6.36.461.g798e)]
Date: Wed, 30 Jun 2010 23:05:49 +0200	[thread overview]
Message-ID: <87iq50griq.wl%n.goaziou@gmail.com> (raw)
In-Reply-To: <871vbouu7f.fsf@gmail.com>

Hi Eric,

I do not think this is the right fix. You are only allowing lines
like :

---
     # a line of text
---

to be treated as comments, when they are not! The first regex is the
one matching comments definition (# on column 0 and '#+ ' everywhere).
Handling of lines like #+ATTR_LaTeX should be processed outside of
comments handling functions to not add confusion.

Moreover, I mailed a fix earlier (see thread with Sebastian Rose:
unwanted #+attr_backend and #+backend stuff) which already solves that
problem, among others.

Regards,

-- Nicolas

  parent reply	other threads:[~2010-06-30 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30 18:49 Bug: #+ATTR_LaTeX broken in LaTeX export [6.36trans (release_6.36.461.g798e)] Tassilo Horn
2010-06-30 19:44 ` Sébastien Vauban
2010-06-30 20:44   ` Eric Schulte
2010-06-30 20:58     ` Sébastien Vauban
2010-06-30 21:05     ` Nicolas Goaziou [this message]
2010-06-30 21:26       ` Eric Schulte
2010-06-30 22:22         ` Nicolas Goaziou
2010-06-30 22:49           ` Eric Schulte
2010-06-30 23:03             ` Eric Schulte
2010-07-01  4:44             ` Tassilo Horn
2010-07-01  7:48               ` Carsten Dominik
2010-07-01  8:33                 ` Bernt Hansen
2010-07-01  9:03                   ` Carsten Dominik
2010-07-01  7:25           ` Sébastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iq50griq.wl%n.goaziou@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=schulte.eric@gmail.com \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).