[FEATURE] mobile-org on android don't show the hours of the event

[FEATURE] mobile-org on android don't show the hours of the event

[Rémi Vanicat]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hello list,

When looking at the agenda on my phone, I can't see the hours of the
events I'm looking at. It seem the information is available (it's in the
agenda.org that is used by android's mobile-org to show, but I can't
understand how to make my android phone)

There is a patch to org-mobile.el that make the times visible on my
phone. I don't know how it will shine on others phone (I've no iphone to
test it), and even if the choice to hide this is seen as a feature for
some. 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Show-the-time-in-org-mobile-agenda.patch --]
[-- Type: text/x-diff, Size: 1613 bytes --]

From 0ce98d4f5606cade97edfc4165bf1119e1fcb1ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Vanicat?= <vanicat@debian.org>
Date: Sun, 3 Apr 2011 11:36:02 +0200
Subject: [PATCH] Show the time in org-mobile agenda.

---
 lisp/org-mobile.el |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 83462f0..af3c8b1 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -597,7 +597,7 @@ The table of checksums is written to the file mobile-checksums."
 
 (defvar org-mobile-creating-agendas nil)
 (defun org-mobile-write-agenda-for-mobile (file)
-  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp)
+  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp time)
     (with-temp-file file
       (org-mode)
       (insert "#+READONLY\n")
@@ -630,6 +630,7 @@ The table of checksums is written to the file mobile-checksums."
 		      (get-text-property (point) 'org-marker)))
 	  (setq sexp (member (get-text-property (point) 'type)
 			     '("diary" "sexp")))
+	  (setq time (get-text-property (point) 'time))
 	  (if (setq pl (text-property-any (point) (point-at-eol) 'org-heading t))
 	      (progn
 		(setq prefix (org-trim (buffer-substring
@@ -638,6 +639,8 @@ The table of checksums is written to the file mobile-checksums."
 				      pl
 				      (point-at-eol))))
 		(delete-region (point-at-bol) (point-at-eol))
+		(when time
+		  (insert time " "))
 		(insert line "<before>" prefix "</before>")
 		(beginning-of-line 1))
 	    (and (looking-at "[ \t]+") (replace-match "")))
-- 
1.7.4.1


[-- Attachment #3: Type: text/plain, Size: 19 bytes --]


-- 
Rémi Vanicat

Re: [FEATURE] mobile-org on android don't show the hours of the event

[Carsten Dominik]

Hi Remi,

On Apr 3, 2011, at 1:45 PM, Rémi Vanicat wrote:

> Hello list,
> 
> When looking at the agenda on my phone, I can't see the hours of the
> events I'm looking at. It seem the information is available (it's in the
> agenda.org that is used by android's mobile-org to show, but I can't
> understand how to make my android phone)
> 
> There is a patch to org-mobile.el that make the times visible on my
> phone. I don't know how it will shine on others phone (I've no iphone to
> test it), and even if the choice to hide this is seen as a feature for
> some. 
> 

Could you please show an example?  Show us an entry in the Org file,
what it looks like on an iphone (if possible) and what it looks like
on your Android.  Only then we can judge if this is an issue
with MobileOrg for Android, or with Org-mode itself.

- Carsten

> From 0ce98d4f5606cade97edfc4165bf1119e1fcb1ff Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?R=C3=A9mi=20Vanicat?= <vanicat@debian.org>
> Date: Sun, 3 Apr 2011 11:36:02 +0200
> Subject: [PATCH] Show the time in org-mobile agenda.
> 
> ---
> lisp/org-mobile.el |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index 83462f0..af3c8b1 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -597,7 +597,7 @@ The table of checksums is written to the file mobile-checksums."
> 
> (defvar org-mobile-creating-agendas nil)
> (defun org-mobile-write-agenda-for-mobile (file)
> -  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp)
> +  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp time)
>     (with-temp-file file
>       (org-mode)
>       (insert "#+READONLY\n")
> @@ -630,6 +630,7 @@ The table of checksums is written to the file mobile-checksums."
> 		      (get-text-property (point) 'org-marker)))
> 	  (setq sexp (member (get-text-property (point) 'type)
> 			     '("diary" "sexp")))
> +	  (setq time (get-text-property (point) 'time))
> 	  (if (setq pl (text-property-any (point) (point-at-eol) 'org-heading t))
> 	      (progn
> 		(setq prefix (org-trim (buffer-substring
> @@ -638,6 +639,8 @@ The table of checksums is written to the file mobile-checksums."
> 				      pl
> 				      (point-at-eol))))
> 		(delete-region (point-at-bol) (point-at-eol))
> +		(when time
> +		  (insert time " "))
> 		(insert line "<before>" prefix "</before>")
> 		(beginning-of-line 1))
> 	    (and (looking-at "[ \t]+") (replace-match "")))
> -- 
> 1.7.4.1
> 
> 
> -- 
> Rémi Vanicat

- Carsten

Re: [FEATURE] mobile-org on android don't show the hours of the event

[Rémi Vanicat]

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hi Remi,
>
> On Apr 3, 2011, at 1:45 PM, Rémi Vanicat wrote:
>
>> Hello list,
>> 
>> When looking at the agenda on my phone, I can't see the hours of the
>> events I'm looking at. It seem the information is available (it's in the
>> agenda.org that is used by android's mobile-org to show, but I can't
>> understand how to make my android phone)
>> 
>> There is a patch to org-mobile.el that make the times visible on my
>> phone. I don't know how it will shine on others phone (I've no iphone to
>> test it), and even if the choice to hide this is seen as a feature for
>> some. 
>> 
>
> Could you please show an example?  Show us an entry in the Org file,
> what it looks like on an iphone (if possible) and what it looks like
> on your Android.  

The entry in tho org-file is:

#+begin_src org-mode
**** 10:15-11:15 Seconde 1 I15
     :PROPERTIES:
     :ID:       95e9b4c0-d4cc-4fb0-a451-f9d566700d48
          :END:
     <%%(org-diary-class 01 09 2010 11 06 2011 1 51 52 08 09 16 17)>
#+end_src


The entry in the generated agenda.org is:
#+begin_src org-mode
***  Seconde 1 I15<before>cours:      10:15-11:15</before>
   <%%(org-diary-class 01 09 2010 11 06 2011 1 51 52 08 09 16 17)>
   :PROPERTIES:
   :ORIGINAL_ID: 95e9b4c0-d4cc-4fb0-a451-f9d566700d48
   :END:
#+end_src

On my android, in the "Agenda View" it appear as

Seconde 1 I15

It appear correctly as 

10:15-11:15 Seconde 1 I15

in the view of cours.org 

> Only then we can judge if this is an issue
> with MobileOrg for Android, or with Org-mode itself.
>
> - Carsten
>
>> From 0ce98d4f5606cade97edfc4165bf1119e1fcb1ff Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?R=C3=A9mi=20Vanicat?= <vanicat@debian.org>
>> Date: Sun, 3 Apr 2011 11:36:02 +0200
>> Subject: [PATCH] Show the time in org-mobile agenda.
>> 
>> ---
>> lisp/org-mobile.el |    5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>> 
>> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
>> index 83462f0..af3c8b1 100644
>> --- a/lisp/org-mobile.el
>> +++ b/lisp/org-mobile.el
>> @@ -597,7 +597,7 @@ The table of checksums is written to the file mobile-checksums."
>> 
>> (defvar org-mobile-creating-agendas nil)
>> (defun org-mobile-write-agenda-for-mobile (file)
>> -  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp)
>> +  (let ((all (buffer-string)) in-date id pl prefix line app short m sexp time)
>>     (with-temp-file file
>>       (org-mode)
>>       (insert "#+READONLY\n")
>> @@ -630,6 +630,7 @@ The table of checksums is written to the file mobile-checksums."
>> 		      (get-text-property (point) 'org-marker)))
>> 	  (setq sexp (member (get-text-property (point) 'type)
>> 			     '("diary" "sexp")))
>> +	  (setq time (get-text-property (point) 'time))
>> 	  (if (setq pl (text-property-any (point) (point-at-eol) 'org-heading t))
>> 	      (progn
>> 		(setq prefix (org-trim (buffer-substring
>> @@ -638,6 +639,8 @@ The table of checksums is written to the file mobile-checksums."
>> 				      pl
>> 				      (point-at-eol))))
>> 		(delete-region (point-at-bol) (point-at-eol))
>> +		(when time
>> +		  (insert time " "))
>> 		(insert line "<before>" prefix "</before>")
>> 		(beginning-of-line 1))
>> 	    (and (looking-at "[ \t]+") (replace-match "")))
>> -- 
>> 1.7.4.1
>> 
>> 
>> -- 
>> Rémi Vanicat
>
> - Carsten
>
>
>

-- 
Rémi Vanicat