From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: [PATCH 2/7] New macro: Evaluate FORM in ENVIRONMENT Date: Tue, 02 Aug 2011 15:25:21 +0200 Message-ID: <87ipqgaqta.wl%dmaus@ictsoc.de> References: <1312277020-7888-1-git-send-email-dmaus@ictsoc.de> <1312277020-7888-3-git-send-email-dmaus@ictsoc.de> <87fwlk3x5u.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Tue_Aug__2_15:25:21_2011-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:54866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoEyN-0004Vt-67 for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 09:25:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoEyL-0003A1-TM for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 09:25:27 -0400 Received: from app1b.xlhost.de ([213.202.242.162]:49900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoEyL-00039u-M0 for emacs-orgmode@gnu.org; Tue, 02 Aug 2011 09:25:25 -0400 In-Reply-To: <87fwlk3x5u.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?UTF-8?B?xaB0xJtww6FuIE7Em21lYw==?= Cc: David Maus , emacs-orgmode@gnu.org --pgp-sign-Multipart_Tue_Aug__2_15:25:21_2011-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable At Tue, 02 Aug 2011 12:50:05 +0200, =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec wrote: >=20 > On Tue, 02 Aug 2011 11:23:35 +0200 > David Maus wrote: >=20 > > * org-macs.el (org-eval-in-environment): New macro. Evaluate > > FORM in ENVIRONMENT. > > (org-with-uninterned): Move to top of file. > > --- > > lisp/org-macs.el | 23 ++++++++++++++++++----- > > 1 files changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/lisp/org-macs.el b/lisp/org-macs.el > > index 53c60e5..7a0cc60 100644 > > --- a/lisp/org-macs.el > > +++ b/lisp/org-macs.el > > @@ -47,6 +47,12 @@ > > (declare-function org-add-props "org-compat" (string plist &rest props= )) > > (declare-function org-string-match-p "org-compat" (&rest args)) > > =20 > > +(defmacro org-with-uninterned (symbols &rest body) > > + `(let ,(mapcar (lambda (s) > > + `(,s (make-symbol (symbol-name ',s)))) symbols) > > + ,@body)) > > +(put 'org-with-uninterned 'lisp-indent-function 1) > > + >=20 > So in the previous commit you added this macro, in the next commit you > move it to the top of the file? Why didn't you put it into the right > place to begin with? >=20 > [...] >=20 > > +(defun org-make-parameter-alist (flat) > > + "Return alist based on FLAT. > > +FLAT is a list with alternating symbol names and values. The > > +returned alist is a list of lists with the symbol name in car and > > +the value in cdr." > > + (when flat > > + (cons (list (car flat) (cadr flat)) > > + (org-make-parameter-alist (cddr flat))))) >=20 > This new function is not mentioned anywhere in the commit message. Yepp. I messed up the branch, correction is on its way. Best, -- David --=20 OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Tue_Aug__2_15:25:21_2011-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAk43+sEACgkQma24O1pEeOZvHwEAoVyZM+5vggySmwgbfguJTBYZ 5EyxJVJYPlV983toLpABAIvaRFDHvPkeqa8WfbM6tMO17hwrzLBNENUrydhyLMJ6 =gZaX -----END PGP SIGNATURE----- --pgp-sign-Multipart_Tue_Aug__2_15:25:21_2011-1--