From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Byte compiler warnings Date: Sat, 22 Oct 2011 16:31:25 +0200 Message-ID: <87ipnhhzcy.fsf@gnu.org> References: <87ty712jua.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:60918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHcap-00043d-U3 for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 10:30:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RHcao-00025e-M6 for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 10:30:35 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:40901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RHcao-00025R-DH for emacs-orgmode@gnu.org; Sat, 22 Oct 2011 10:30:34 -0400 Received: by wyg34 with SMTP id 34so5759454wyg.0 for ; Sat, 22 Oct 2011 07:30:33 -0700 (PDT) In-Reply-To: <87ty712jua.fsf@Rainer.invalid> (Achim Gratz's message of "Sat, 22 Oct 2011 16:15:41 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > Recently the byte compiler has become increasingly dissatisfied with the > orgmode code again... :-) > > Emacs24 complains about these: > > In org-agenda-get-blocks: > org-agenda.el:5434:42:Warning: assignment to free variable `category-pos' > org-agenda.el:5434:20:Warning: reference to free variable > `category-pos' I just fixed this. > That actually has been there for a while. Yes, my bad. > In org-edit-src-code: > org-src.el:295:14:Warning: reference to free variable `eq' This is also fixed. > That's most likely a bug involving a comparison, in any case if "eq" really is a variable it > surely needs a different name. > > In org-babel-get-lob-one-liner-matches: > ob.el:191:21:Warning: reference to free variable > `org-babel-inline-lob-one-liner-regexp' Fixed. > In org-babel-execute:shen: > ob-shen.el:68:32:Warning: reference to free variable `result-params' > ob-shen.el:72:19:Warning: reference to free variable `result' I expect Eric will take care of this. > > In end of data: > org.el:20874:1:Warning: the function `cdlatex-compute-tables' is not known to > be defined. Fixed. > I don't know if a package needs to be required or the function > declared. The function needs to be declared. > Emacs23 additionally complains about: > > In org-mode: > org.el:4870:9:Warning: assignment to free variable `bidi-paragraph-direction' > > In end of data: > org.el:20874:1:Warning: the function `format-spec' might not be defined at > runtime. > > It looks like these functions don't exist in Emacs23 and need to be > protected via version-dependent wrappers. On my todo list. Thanks for the careful check! -- Bastien