Re: Byte compiler warnings

[Bastien <bzg@altern.org>]

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Recently the byte compiler has become increasingly dissatisfied with the
> orgmode code again... :-)
>
> Emacs24 complains about these:
>
> In org-agenda-get-blocks:
> org-agenda.el:5434:42:Warning: assignment to free variable `category-pos'
> org-agenda.el:5434:20:Warning: reference to free variable
> `category-pos'

I just fixed this.

> That actually has been there for a while.

Yes, my bad.

> In org-edit-src-code:
> org-src.el:295:14:Warning: reference to free variable `eq'

This is also fixed.

> That's most likely a bug involving a comparison, in any case if "eq" really is a variable it
> surely needs a different name.
>
> In org-babel-get-lob-one-liner-matches:
> ob.el:191:21:Warning: reference to free variable
>     `org-babel-inline-lob-one-liner-regexp'

Fixed.

> In org-babel-execute:shen:
> ob-shen.el:68:32:Warning: reference to free variable `result-params'
> ob-shen.el:72:19:Warning: reference to free variable `result'

I expect Eric will take care of this.
>
> In end of data:
> org.el:20874:1:Warning: the function `cdlatex-compute-tables' is not known to
>     be defined.

Fixed.

> I don't know if a package needs to be required or the function
> declared.

The function needs to be declared.

> Emacs23 additionally complains about:
>
> In org-mode:
> org.el:4870:9:Warning: assignment to free variable `bidi-paragraph-direction'
>
> In end of data:
> org.el:20874:1:Warning: the function `format-spec' might not be defined at
>     runtime.
>
> It looks like these functions don't exist in Emacs23 and need to be
> protected via version-dependent wrappers.

On my todo list.

Thanks for the careful check!

-- 
 Bastien