emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Matt Lundin <mdl@imapmail.org>
To: Bastien <bzg@gnu.org>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: Problems with (defvar foo) and Emacs 23
Date: Sat, 07 Apr 2012 07:15:30 -0500	[thread overview]
Message-ID: <87iphbrb4t.fsf@fastmail.fm> (raw)
In-Reply-To: <87bona64ri.fsf@gnu.org> (Bastien's message of "Mon, 02 Apr 2012 08:12:49 +0200")

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Bastien <bzg@gnu.org> writes:
>
> I fixed the problem with `org-clock-state'.  This should be `org-state'.
>
> `state' is a local variable in many org.el functions, I renamed it to
> `org-state' in org-clock.el and in "caller" sexp from org.el.  
>

Attached please find a patch that fixes the docstring of
org-after-todo-state-change-hook to reflect this change.

Best,
Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-hook-docstring-to-reflect-renaming-of-state-to-o.patch --]
[-- Type: text/x-patch, Size: 1061 bytes --]

From f21889985f2008bc77e2ecfc38be481a47c9916c Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Sat, 7 Apr 2012 07:13:55 -0500
Subject: [PATCH] Fix hook docstring to reflect renaming of state to
 org-state.

* lisp/org.el: (org-after-todo-state-change-hook): Fix docstring to
  reflect name change of state to org-state.

The renamed variable can cause user hooks added to
org-after-todo-state-change-hook to break, so it is essential to have
the correct variable name in the docstring.
---
 lisp/org.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index a11d734..e7c579d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2231,7 +2231,7 @@ property and include the word \"recursive\" into the value."
 (defcustom org-after-todo-state-change-hook nil
   "Hook which is run after the state of a TODO item was changed.
 The new state (a string with a TODO keyword, or nil) is available in the
-Lisp variable `state'."
+Lisp variable `org-state'."
   :group 'org-todo
   :type 'hook)
 
-- 
1.7.10


  reply	other threads:[~2012-04-07 12:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-01 18:57 Problems with (defvar foo) and Emacs 23 Bernt Hansen
2012-04-01 20:16 ` Achim Gratz
2012-04-01 20:29   ` [URGENT] " Achim Gratz
2012-04-02  6:15     ` Bastien
2012-04-01 20:37   ` Bastien
2012-04-01 21:18     ` Achim Gratz
2012-04-02  0:53       ` Nick Dokos
2012-04-02  5:31         ` Achim Gratz
2012-04-02  6:01           ` Nick Dokos
2012-04-02  8:21             ` Bastien
2012-04-02  6:28           ` Bastien
2012-04-02  6:27       ` Bastien
2012-04-02 18:11         ` Achim Gratz
2012-04-03  5:49           ` Bastien
2012-04-03  6:04             ` Achim Gratz
2012-04-04  7:25               ` Bastien
2012-04-02  6:12   ` Bastien
2012-04-07 12:15     ` Matt Lundin [this message]
2012-04-09 14:57       ` Bastien
2012-04-01 20:46 ` Nick Dokos
2012-04-01 20:48   ` Bernt Hansen
2012-04-02  6:09   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iphbrb4t.fsf@fastmail.fm \
    --to=mdl@imapmail.org \
    --cc=Stromeko@nexgo.de \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).