From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: test-ob-sh/session Date: Fri, 03 Aug 2012 22:25:36 +0200 Message-ID: <87ipczu3i7.fsf@Rainer.invalid> References: <87vch1cdy4.fsf@Rainer.invalid> <87zk6bu5sv.fsf@gmx.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:48140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxORX-0006M4-2Y for emacs-orgmode@gnu.org; Fri, 03 Aug 2012 16:25:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxORV-0003zG-PI for emacs-orgmode@gnu.org; Fri, 03 Aug 2012 16:25:54 -0400 Received: from plane.gmane.org ([80.91.229.3]:47623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxORV-0003z5-Iw for emacs-orgmode@gnu.org; Fri, 03 Aug 2012 16:25:53 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SxORR-0002Og-3q for emacs-orgmode@gnu.org; Fri, 03 Aug 2012 22:25:49 +0200 Received: from pd9eb4a66.dip.t-dialin.net ([217.235.74.102]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 03 Aug 2012 22:25:49 +0200 Received: from Stromeko by pd9eb4a66.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 03 Aug 2012 22:25:49 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Eric Schulte writes: > There are a number of tests which execute shell code blocks in > test-ob.el. This file has no guards, so it will be run on every > system. I know, I'm not (currently) talking about these. What puzzles me is that the three tests in test-ob-sh get defined and run even though the feature ob-sh is not available. It may be that this gets somehow subverted by having the other tests unguarded, but I can't see how. > I guess at the time I wrote these tests I assumed that every system > would support both emacs-lisp and sh code blocks. Specifically a shell that is more or less POSIX compatible... even though even tcsh passes all tests. :-) > At some point either > > 1. all tests in test-ob.el which run sh code blocks should be placed > behind conditional guards so they are only loaded when shell support > is present That would be preferrable for tests which really depend on a shell being available. > 2. all tests in test-ob.el which run sh code blocks should be switched > to running emacs-lisp code blocks And this would be preferred for tests which should always be run without making any assumptions on the environment. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada