From mboxrd@z Thu Jan  1 00:00:00 1970
From: jemarch@gnu.org (Jose E. Marchesi)
Subject: Re: [PATCH] Translate refs to rc also in remote references
Date: Thu, 09 Aug 2012 20:00:06 +0200
Message-ID: <87ipcs2bfd.fsf@gnu.org>
References: <87y5mrdbcn.fsf@gnu.org> <87mx37crmg.fsf@gnu.org>
	<87ehoivhio.fsf@gnu.org> <87ehnhy3m6.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:59998)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jemarch@gnu.org>) id 1Szd18-0002gr-6w
	for emacs-orgmode@gnu.org; Thu, 09 Aug 2012 20:23:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jemarch@gnu.org>) id 1Szd17-0001lp-4N
	for emacs-orgmode@gnu.org; Thu, 09 Aug 2012 20:23:54 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:58979)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jemarch@gnu.org>) id 1Szd17-0001ll-0z
	for emacs-orgmode@gnu.org; Thu, 09 Aug 2012 20:23:53 -0400
In-Reply-To: <87ehnhy3m6.fsf@gnu.org> (Bastien's message of "Wed, 08 Aug 2012
	14:23:13 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org


Hi Bastien.
    

    > -    (while (string-match "\\<\\([a-zA-Z]+\\)\\([0-9]+\\>\\|&\\)\\|\\(;[^\r\n:]+\\|\\<remote([^)]*)\\)" s start)
    > +    (while (string-match "\\<\\([a-zA-Z]+\\)\\([0-9]+\\>\\|&\\)\\|\\(;[^\r\n:]+\\|\\<remote([^,]*[ \t]*\\|)\\)" s start)
    
    I fail to see the meaning of ([^,]*[ \t]*\\|) replacing ([^)]*)
    
    The \\| is wrong, right?

Yep, you can remove the \\|.
    
    I think I need an example with such a remote reference, the way
    org-table-convert-refs-to-rc would have converted it, and the way
    it does with your patch.

Real example from a formula in a table of mine:

  B3=(B2*remote(Factors,F10))/remote(Factors,G10)

The old org-table-convert-refs-to-rc would have converted it to:

"@3$2=(@2$2*remote(Factors,F10))/remote(Factors,G10)"
  
The new version to:

"@3$2=(@2$2*remote(Factors,@10$6))/remote(Factors,@10$7)"

i.e. the old version was not converting the A0 coordinates to rc
coordinates.

-- 
Jose E. Marchesi         http://www.jemarch.net
GNU Project              http://www.gnu.org