emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: jemarch@gnu.org (Jose E. Marchesi)
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Translate refs to rc also in remote references
Date: Thu, 09 Aug 2012 20:00:06 +0200	[thread overview]
Message-ID: <87ipcs2bfd.fsf@gnu.org> (raw)
In-Reply-To: <87ehnhy3m6.fsf@gnu.org> (Bastien's message of "Wed, 08 Aug 2012 14:23:13 +0200")


Hi Bastien.
    

    > -    (while (string-match "\\<\\([a-zA-Z]+\\)\\([0-9]+\\>\\|&\\)\\|\\(;[^\r\n:]+\\|\\<remote([^)]*)\\)" s start)
    > +    (while (string-match "\\<\\([a-zA-Z]+\\)\\([0-9]+\\>\\|&\\)\\|\\(;[^\r\n:]+\\|\\<remote([^,]*[ \t]*\\|)\\)" s start)
    
    I fail to see the meaning of ([^,]*[ \t]*\\|) replacing ([^)]*)
    
    The \\| is wrong, right?

Yep, you can remove the \\|.
    
    I think I need an example with such a remote reference, the way
    org-table-convert-refs-to-rc would have converted it, and the way
    it does with your patch.

Real example from a formula in a table of mine:

  B3=(B2*remote(Factors,F10))/remote(Factors,G10)

The old org-table-convert-refs-to-rc would have converted it to:

"@3$2=(@2$2*remote(Factors,F10))/remote(Factors,G10)"
  
The new version to:

"@3$2=(@2$2*remote(Factors,@10$6))/remote(Factors,@10$7)"

i.e. the old version was not converting the A0 coordinates to rc
coordinates.

-- 
Jose E. Marchesi         http://www.jemarch.net
GNU Project              http://www.gnu.org

  reply	other threads:[~2012-08-10  0:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 12:55 [PATCH] Translate refs to rc also in remote references Jose E. Marchesi
2012-07-10 20:01 ` Bastien
2012-07-11  8:17   ` Jose E. Marchesi
2012-08-08 12:23     ` Bastien
2012-08-09 18:00       ` Jose E. Marchesi [this message]
2012-08-10  9:02         ` Bastien
2012-08-10  9:23           ` Jose E. Marchesi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipcs2bfd.fsf@gnu.org \
    --to=jemarch@gnu.org \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).