From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: babel perl issue Date: Wed, 12 Dec 2012 17:23:59 +0100 Message-ID: <87ip871bog.fsf@bzg.ath.cx> References: <87a9tntr29.fsf@Rainer.invalid> <87sj7fp7om.fsf@gmail.com> <87wqwrrml2.fsf@Rainer.invalid> <87vcca9bxw.fsf@gmail.com> <87d2yhvm3c.fsf@Rainer.invalid> <87obi193mn.fsf@gmail.com> <87zk1lu53s.fsf@Rainer.invalid> <87zk1kmpyo.fsf@gmail.com> <87r4mwph61.fsf@bzg.ath.cx> <87zk1kf2bw.fsf@gmail.com> <8762472rg8.fsf@bzg.ath.cx> <874njrdzdg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tip6S-0006Ur-13 for emacs-orgmode@gnu.org; Wed, 12 Dec 2012 11:24:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tip6M-0003aA-5K for emacs-orgmode@gnu.org; Wed, 12 Dec 2012 11:24:11 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:37902) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tip6L-0003a4-Rg for emacs-orgmode@gnu.org; Wed, 12 Dec 2012 11:24:06 -0500 Received: by mail-wi0-f169.google.com with SMTP id hq12so3019947wib.0 for ; Wed, 12 Dec 2012 08:24:05 -0800 (PST) In-Reply-To: <874njrdzdg.fsf@gmail.com> (Eric Schulte's message of "Wed, 12 Dec 2012 09:11:23 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Achim Gratz , emacs-orgmode@gnu.org Hi Eric, Eric Schulte writes: > This is refactoring not bug fixing. The most important impact is that > this will provide for simpler requires by the files implementing support > for particular languages. Rather than having to do piecemeal requires > of those portions of the Babel infrastructure which may be needed > locally they can simple (require 'ob) and bring in all of the Babel > support as a single unit. I agree with the simplification if it does not involved creating ob-core.el and ob-customs.el. Merging ob.el and ob-tangle.el (and perhaps ob-eval.el and ob-comint.el) is a good simplification option IMHO. > Prior to this change there are language specific files which are using > tangle defcustoms which have not been required and thus are not in > scope. Got it. > Finally this consolidates Babel defcustoms into ob.el where they will be > more immediately brought into scope, and are more easily maintained. Yes, if you merge the files; otherwise, I'd stick to the namespace rule: defcustoms belong where their namespace indicate they belong. Thanks, -- Bastien