Compilation warnings and a test failure

Compilation warnings and a test failure

[Nick Dokos]

Just pulled

 Org-mode version 7.9.2 (release_7.9.2-762-gc74c62 @ /home/nick/elisp/org-mode/lisp/)

and running under

 GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.4) of 2012-09-21

I get compilation warnings:

,----
| Compiling /home/nick/src/emacs/org/org-mode/lisp/org.el...
| 
| In org-get-location:
| org.el:6989:10:Warning: `special-display-function' is an obsolete variable (as
|     of 24.3); use `display-buffer-alist' instead.
| org.el:6988:10:Warning: `special-display-regexps' is an obsolete variable (as
|     of 24.3); use `display-buffer-alist' instead.
| org.el:6987:10:Warning: `special-display-buffer-names' is an obsolete variable
|     (as of 24.3); use `display-buffer-alist' instead.
| 
| In org-shiftcontrolup:
| org.el:19234:11:Warning: org-clock-timestamps-up called with 1 argument, but
|     accepts only 0
| 
| In org-shiftcontroldown:
| org.el:19244:11:Warning: org-clock-timestamps-down called with 1 argument, but
|     accepts only 0
| 
| In org-switch-to-buffer-other-window:
| org.el:20957:23:Warning: `special-display-function' is an obsolete variable
|     (as of 24.3); use `display-buffer-alist' instead.
| org.el:20956:52:Warning: `special-display-regexps' is an obsolete variable (as
|     of 24.3); use `display-buffer-alist' instead.
| org.el:20956:23:Warning: `special-display-buffer-names' is an obsolete
|     variable (as of 24.3); use `display-buffer-alist' instead.
| Wrote /home/nick/src/emacs/org/org-mode/lisp/org.elc
`----

and a test failure:

,----
| Test ob-exp/mixed-blocks-with-exports-both backtrace:
|   <(149 nil)
|   apply(< (149 nil))
|   (setq value-4627 (apply fn-4625 args-4626))
|   (unwind-protect (setq value-4627 (apply fn-4625 args-4626)) (setq fo
|   (if (unwind-protect (setq value-4627 (apply fn-4625 args-4626)) (set
|   (unless (unwind-protect (setq value-4627 (apply fn-4625 args-4626)) 
|   (let (form-description-4629) (unless (unwind-protect (setq value-462
|   (let ((value-4627 (quote ert-form-evaluation-aborted-4628))) (let (f
|   (let ((fn-4625 (function <)) (args-4626 (list test-point (re-search-
|   (should (< test-point (re-search-forward x nil t)))
|   (lambda (x) (should (< test-point (re-search-forward x nil t))) (set
|   mapcar((lambda (x) (should (< test-point (re-search-forward x nil t)
|   (progn (mapcar (lambda (x) (should (< test-point (re-search-forward 
|   (setq G48327 (progn (mapcar (lambda (x) (should (< test-point (re-se
|   (let ((kill-buffer-query-functions nil) G48327) (with-temp-file "/tm
|   (org-test-with-temp-text-in-file exported-html (mapcar (lambda (x) (
|   (let ((exported-html (org-export-as-html nil nil nil (quote string) 
|   (save-restriction (org-narrow-to-subtree) (let ((exported-html (org-
|   (progn (org-id-goto "5daa4d03-e3ea-46b7-b093-62c1b7632df3") (setq to
|   (unwind-protect (progn (org-id-goto "5daa4d03-e3ea-46b7-b093-62c1b76
|   (let ((save-match-data-internal (match-data))) (unwind-protect (prog
|   (save-match-data (org-id-goto "5daa4d03-e3ea-46b7-b093-62c1b7632df3"
|   (progn (save-match-data (org-id-goto "5daa4d03-e3ea-46b7-b093-62c1b7
|   (unwind-protect (progn (save-match-data (org-id-goto "5daa4d03-e3ea-
|   (let ((wconfig (current-window-configuration))) (unwind-protect (pro
|   (save-window-excursion (save-match-data (org-id-goto "5daa4d03-e3ea-
|   (let* ((id-location (org-id-find "5daa4d03-e3ea-46b7-b093-62c1b7632d
|   (org-test-at-id "5daa4d03-e3ea-46b7-b093-62c1b7632df3" (org-narrow-t
|   (lambda nil (org-test-at-id "5daa4d03-e3ea-46b7-b093-62c1b7632df3" (
|   byte-code("\306\307!\x18q\210\310\216\311 \x19\312\216\313\314\315\316\3
|   ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
|   byte-code("\306\307!\211\x18\211\x19r\310\311!q\210\312 d\313\223)L\210)\3
|   ert-run-test([cl-struct-ert-test ob-exp/mixed-blocks-with-exports-bo
|   ert-run-or-rerun-test([cl-struct-ert--stats "\\(org\\|ob\\)" [[cl-st
|   ert-run-tests("\\(org\\|ob\\)" #[(event-type &rest event-args) "\306
|   ert-run-tests-batch("\\(org\\|ob\\)")
|   ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
|   (let ((org-id-track-globally t) (org-id-locations-file (convert-stan
|   org-test-run-batch-tests()
|   call-interactively(org-test-run-batch-tests nil nil)
|   command-execute(org-test-run-batch-tests)
|   command-line-1(("--eval" "(add-to-list 'load-path \"./lisp\")" "--ev
|   command-line()
|   normal-top-level()
| Test ob-exp/mixed-blocks-with-exports-both condition:
|     (wrong-type-argument number-or-marker-p nil)
|    FAILED   19/334  ob-exp/mixed-blocks-with-exports-both
`----

Thanks,
Nick

Re: Compilation warnings and a test failure

[Bastien]

Hi Nick,

Nick Dokos <nicholas.dokos@hp.com> writes:

> | In org-get-location:
> | org.el:6989:10:Warning: `special-display-function' is an obsolete variable (as
> |     of 24.3); use `display-buffer-alist' instead.
> | org.el:6988:10:Warning: `special-display-regexps' is an obsolete variable (as
> |     of 24.3); use `display-buffer-alist' instead.
> | org.el:6987:10:Warning: `special-display-buffer-names' is an obsolete variable
> |     (as of 24.3); use `display-buffer-alist' instead.

These are not trivial to fix.  If someone wants to have a look,
please go ahead.

> | In org-shiftcontrolup:
> | org.el:19234:11:Warning: org-clock-timestamps-up called with 1 argument, but
> |     accepts only 0
> | 
> | In org-shiftcontroldown:
> | org.el:19244:11:Warning: org-clock-timestamps-down called with 1 argument, but
> |     accepts only 0

Fixed, thanks.

> | In org-switch-to-buffer-other-window:
> | org.el:20957:23:Warning: `special-display-function' is an obsolete variable
> |     (as of 24.3); use `display-buffer-alist' instead.
> | org.el:20956:52:Warning: `special-display-regexps' is an obsolete variable (as
> |     of 24.3); use `display-buffer-alist' instead.
> | org.el:20956:23:Warning: `special-display-buffer-names' is an obsolete
> |     variable (as of 24.3); use `display-buffer-alist' instead.
> | Wrote /home/nick/src/emacs/org/org-mode/lisp/org.elc

Same as above.

> and a test failure:

Fixed too, thanks!

-- 
 Bastien

Re: Compilation warnings and a test failure

[Achim Gratz]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Bastien writes:
>> | In org-get-location:
>> | org.el:6989:10:Warning: `special-display-function' is an obsolete variable (as
>> |     of 24.3); use `display-buffer-alist' instead.
>> | org.el:6988:10:Warning: `special-display-regexps' is an obsolete variable (as
>> |     of 24.3); use `display-buffer-alist' instead.
>> | org.el:6987:10:Warning: `special-display-buffer-names' is an obsolete variable
>> |     (as of 24.3); use `display-buffer-alist' instead.
>
> These are not trivial to fix.  If someone wants to have a look,
> please go ahead.

Something like this maybe?


[-- Attachment #2: 0001-org-compat-new-macro-org-suppress-popups.patch --]
[-- Type: text/x-patch, Size: 5518 bytes --]

From 089903a29936f00d76fd7bf082603c2dff242a5c Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Thu, 20 Dec 2012 10:18:02 +0100
Subject: [PATCH] org-compat: new macro org-suppress-popups
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lisp/org-compat.el (org-suppress-popups): New wrapper macro,
  let-binds the correct variables to suppress popup windows depending
  on Emacs version.

* lisp/org.el (org-get-location, org-switch-to-buffer-other-window):
  Use the wrapper `org-suppress-popups´ to let-bind variables that are
  version-dependent.
---
 lisp/org-compat.el |  7 +++++
 lisp/org.el        | 86 ++++++++++++++++++++++++++----------------------------
 2 files changed, 48 insertions(+), 45 deletions(-)

diff --git a/lisp/org-compat.el b/lisp/org-compat.el
index 1f330b1..e8983f0 100644
--- a/lisp/org-compat.el
+++ b/lisp/org-compat.el
@@ -375,6 +375,13 @@ (defun org-float-time (&optional time)
 (unless (fboundp 'user-error)
   (defalias 'user-error 'error))
 
+(defmacro org-suppress-popups (&rest body)
+    (if (org-version-check "24.2.50" "" :predicate)
+	`(let (pop-up-frames display-buffer-alist)
+	   ,@body)
+      `(let (pop-up-frames special-display-buffer-names special-display-regexps special-display-function)
+	 ,@body)))
+
 (if (fboundp 'string-match-p)
     (defalias 'org-string-match-p 'string-match-p)
   (defun org-string-match-p (regexp string &optional start)
diff --git a/lisp/org.el b/lisp/org.el
index e93356c..67fb8ed 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -6982,48 +6982,45 @@ (defun org-get-location (buf help)
   "Let the user select a location in the Org-mode buffer BUF.
 This function uses a recursive edit.  It returns the selected position
 or nil."
-  (let ((isearch-mode-map org-goto-local-auto-isearch-map)
-	(isearch-hide-immediately nil)
-	(isearch-search-fun-function
-	 (lambda () 'org-goto-local-search-headings))
-	(org-goto-selected-point org-goto-exit-command)
-	(pop-up-frames nil)
-	(special-display-buffer-names nil)
-	(special-display-regexps nil)
-	(special-display-function nil))
-    (save-excursion
-      (save-window-excursion
-	(delete-other-windows)
-	(and (get-buffer "*org-goto*") (kill-buffer "*org-goto*"))
-	(org-pop-to-buffer-same-window
-	 (condition-case nil
-	     (make-indirect-buffer (current-buffer) "*org-goto*")
-	   (error (make-indirect-buffer (current-buffer) "*org-goto*"))))
-	(with-output-to-temp-buffer "*Help*"
-	  (princ help))
-	(org-fit-window-to-buffer (get-buffer-window "*Help*"))
-	(setq buffer-read-only nil)
-	(let ((org-startup-truncated t)
-	      (org-startup-folded nil)
-	      (org-startup-align-all-tables nil))
-	  (org-mode)
-	  (org-overview))
-	(setq buffer-read-only t)
-	(if (and (boundp 'org-goto-start-pos)
-		 (integer-or-marker-p org-goto-start-pos))
-	    (let ((org-show-hierarchy-above t)
-		  (org-show-siblings t)
-		  (org-show-following-heading t))
-	      (goto-char org-goto-start-pos)
-	      (and (outline-invisible-p) (org-show-context)))
-	  (goto-char (point-min)))
-	(let (org-special-ctrl-a/e) (org-beginning-of-line))
-	(message "Select location and press RET")
-	(use-local-map org-goto-map)
-	(recursive-edit)
-	))
-    (kill-buffer "*org-goto*")
-    (cons org-goto-selected-point org-goto-exit-command)))
+  (org-suppress-popups
+   (let ((isearch-mode-map org-goto-local-auto-isearch-map)
+	 (isearch-hide-immediately nil)
+	 (isearch-search-fun-function
+	  (lambda () 'org-goto-local-search-headings))
+	 (org-goto-selected-point org-goto-exit-command))
+     (save-excursion
+       (save-window-excursion
+	 (delete-other-windows)
+	 (and (get-buffer "*org-goto*") (kill-buffer "*org-goto*"))
+	 (org-pop-to-buffer-same-window
+	  (condition-case nil
+	      (make-indirect-buffer (current-buffer) "*org-goto*")
+	    (error (make-indirect-buffer (current-buffer) "*org-goto*"))))
+	 (with-output-to-temp-buffer "*Help*"
+	   (princ help))
+	 (org-fit-window-to-buffer (get-buffer-window "*Help*"))
+	 (setq buffer-read-only nil)
+	 (let ((org-startup-truncated t)
+	       (org-startup-folded nil)
+	       (org-startup-align-all-tables nil))
+	   (org-mode)
+	   (org-overview))
+	 (setq buffer-read-only t)
+	 (if (and (boundp 'org-goto-start-pos)
+		  (integer-or-marker-p org-goto-start-pos))
+	     (let ((org-show-hierarchy-above t)
+		   (org-show-siblings t)
+		   (org-show-following-heading t))
+	       (goto-char org-goto-start-pos)
+	       (and (outline-invisible-p) (org-show-context)))
+	   (goto-char (point-min)))
+	 (let (org-special-ctrl-a/e) (org-beginning-of-line))
+	 (message "Select location and press RET")
+	 (use-local-map org-goto-map)
+	 (recursive-edit)
+	 ))
+     (kill-buffer "*org-goto*")
+     (cons org-goto-selected-point org-goto-exit-command))))
 
 (defvar org-goto-local-auto-isearch-map (make-sparse-keymap))
 (set-keymap-parent org-goto-local-auto-isearch-map isearch-mode-map)
@@ -20967,9 +20964,8 @@ (defun org-switch-to-buffer-other-window (&rest args)
   "Switch to buffer in a second window on the current frame.
 In particular, do not allow pop-up frames.
 Returns the newly created buffer."
-  (let (pop-up-frames special-display-buffer-names special-display-regexps
-		      special-display-function)
-    (apply 'switch-to-buffer-other-window args)))
+  (org-suppress-popups
+   (apply 'switch-to-buffer-other-window args)))
 
 (defun org-combine-plists (&rest plists)
   "Create a single property list from all plists in PLISTS.
-- 
1.8.0.1


[-- Attachment #3: Type: text/plain, Size: 574 bytes --]



>> | In org-shiftcontrolup:
>> | org.el:19234:11:Warning: org-clock-timestamps-up called with 1 argument, but
>> |     accepts only 0
>> | 
>> | In org-shiftcontroldown:
>> | org.el:19244:11:Warning: org-clock-timestamps-down called with 1 argument, but
>> |     accepts only 0
>
> Fixed, thanks.
[...]
> Same as above.
>
>> and a test failure:
>
> Fixed too, thanks!

Confirmed.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: Compilation warnings and a test failure

[Bastien]

Achim Gratz <Stromeko@nexgo.de> writes:

> Something like this maybe?

Yes, exactly.  Thanks for this patch.

Can you just rename `org-suppress-popups' to `org-no-popups' and 
add a docstring to the macro?  Then feel free to commit and push.

-- 
 Bastien