From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: Exporter interface question
Date: Thu, 28 Feb 2013 11:22:06 +0100
Message-ID: <87ip5cpwkx.fsf@gmail.com>
References: <DC6371D0-B65B-4BCE-8EDD-AFDE9ED812EB@gmail.com>
	<871uc2t9z7.fsf@gmail.com>
	<8993D674-E5E6-4B8E-AE3C-75F694371459@gmail.com>
	<8738whsrx3.fsf@gmail.com>
	<BE6C7742-48F1-4E2A-874F-8D528206FC7F@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:59046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UB0d3-0001Fw-EB
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 05:22:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UB0d2-0001J8-Gl
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 05:22:21 -0500
Received: from mail-wg0-f50.google.com ([74.125.82.50]:57830)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UB0d2-0001J0-B3
	for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 05:22:20 -0500
Received: by mail-wg0-f50.google.com with SMTP id es5so1320711wgb.29
	for <emacs-orgmode@gnu.org>; Thu, 28 Feb 2013 02:22:19 -0800 (PST)
In-Reply-To: <BE6C7742-48F1-4E2A-874F-8D528206FC7F@gmail.com> (Carsten
	Dominik's message of "Thu, 28 Feb 2013 09:39:18 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org-mode List <emacs-orgmode@gnu.org>

Hello,

Carsten Dominik <carsten.dominik@gmail.com> writes:

> OK, I pushed this change, maybe it is good if you have a brief look,
> Nicolas.

Thanks for the patch. It looks good. I have one minor suggestion,
though. In the following snippet:

  (eq (marker-buffer org-export-dispatch-last-position)
  		   (current-buffer))

wouldn't it be better to check equality with:

  (org-base-buffer (current-buffer))

instead or simply (current-buffer)?

> It was great fun and educational to study your very clear code.

Thank you. 


Regards,

-- 
Nicolas Goaziou