From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: org-store-link calls external link type store functions twice?
Date: Tue, 14 May 2013 10:41:01 +0200
Message-ID: <87ip2mlyp0.fsf@bzg.ath.cx>
References: <CAF_idWDZ55HDyTKrHAW=p-0uOaqDpKcNeRJaKsMcdcvUAhL_GA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:36199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UcBA1-0007zV-0O
	for emacs-orgmode@gnu.org; Tue, 14 May 2013 05:04:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UcB9w-0006Ef-8V
	for emacs-orgmode@gnu.org; Tue, 14 May 2013 05:04:40 -0400
Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:61819)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UcB9w-0006ET-2d
	for emacs-orgmode@gnu.org; Tue, 14 May 2013 05:04:36 -0400
Received: by mail-we0-f180.google.com with SMTP id n5so224954wev.39
	for <emacs-orgmode@gnu.org>; Tue, 14 May 2013 02:04:35 -0700 (PDT)
In-Reply-To: <CAF_idWDZ55HDyTKrHAW=p-0uOaqDpKcNeRJaKsMcdcvUAhL_GA@mail.gmail.com>
	(Robert Adesam's message of "Tue, 7 May 2013 21:51:37 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Robert Adesam <robert@adesam.se>
Cc: emacs-orgmode@gnu.org

Hi Robert,

Robert Adesam <robert@adesam.se> writes:

> I am not sure this is a bug but in version 8.x storing a link using
> an external link type, org-store-link seems to call the external link
> type's store function twice... I noticed this as I use an external
> link type that asynchronous updates an external filedatabase and
> started to get random file lock errors -- the org-store-link second
> call to the external link type's store function sometimes came too
> quickly after the first one. :-) Also, I do not have this problem in
> version 7.x of orgmode.
>
> Instead of reverting back to a previous version of orgmode I started
> to investigate -- attaching a patch that seems to help me anyway.
> It's not that well tested and maybe, as I am not that familiar with
> everything going on when storing a link using an external link type,
> it will break other things...

I re-read `org-store-link' and I don't see how the external function
can be called twice... maybe you can give more details on what this
external function looks like, when it is called (within a script or 
something), etc?  

Thanks!

-- 
 Bastien