bug#16270: Incorrect custom types

bug#16270: Incorrect custom types

[Glenn Morris]

Package: org-mode

This refers to the version of Org mode in Emacs trunk.
The following variables have incorrect custom types:

org-babel-latex-htlatex-packages   ; prob. you want repeat, not list
org-export-with-creator       ; const should not be quoted
org-babel-lob-files

There are many other places where the argument of a const is quoted.
This is probably not what you want.

org-agenda.el:			 (choice (const :tag "Day" 'day)
org-agenda.el:				 (const :tag "Week" 'week)
org-agenda.el:				 (const :tag "Fortnight" 'fortnight)
org-agenda.el:				 (const :tag "Month" 'month)
org-agenda.el:				 (const :tag "Year" 'year)
org-agenda.el:				    (list :tag "Regexp matches" :inline t (const :format "" 'regexp) (regexp))
org-agenda.el:				    (list :tag "Regexp does not match" :inline t (const :format "" 'notregexp) (regexp))
org-agenda.el:					  (const 'todo)
org-agenda.el:					   (const :tag "any not-done state" 'todo)
org-agenda.el:					   (const :tag "any done state" 'done)
org-agenda.el:					   (const :tag "any state" 'any)
org-agenda.el:					  (const 'nottodo)
org-agenda.el:					   (const :tag "any not-done state" 'todo)
org-agenda.el:					   (const :tag "any done state" 'done)
org-agenda.el:					   (const :tag "any state" 'any)
org-agenda.el:				    (const :tag "scheduled" 'scheduled)
org-agenda.el:				    (const :tag "not scheduled" 'notscheduled)
org-agenda.el:				    (const :tag "deadline" 'deadline)
org-agenda.el:				    (const :tag "no deadline" 'notdeadline)
org-agenda.el:				    (const :tag "timestamp" 'timestamp)
org-agenda.el:				    (const :tag "no timestamp" 'nottimestamp))))))
org-agenda.el:		 (const :tag "Show only log items" 'only)
org-agenda.el:		 (const :tag "Show all possible log items" 'clockcheck)
org-agenda.el:			 (choice (const :tag "Show closed log items" 'closed)
org-agenda.el:				 (const :tag "Show clocked log items" 'clock)
org-agenda.el:				 (const :tag "Show all logged state changes" 'state)))))
org-agenda.el:	  (const :tag "Always show inherited tags" 'always)
org.el:		 (const :tag "In active region, headlines at the same level than the first one" 'start-level)
org.el:	  (const :tag "A double click follows the link" 'double)
org.el:	  (const :tag "Yes, including all entries" 'all-headlines)
ox.el:	  (const :tag "Sentence as a comment" 'comment)

bug#16270: Incorrect custom types

[Glenn Morris]

Also, the following have no :type at all:

org-babel-maxima-command
org-texinfo-def-table-markup
org-inlinetask-show-first-star

bug#16270: Incorrect custom types

[Bastien]

Glenn Morris <rgm@gnu.org> writes:

> Also, the following have no :type at all:
>
> org-babel-maxima-command
> org-texinfo-def-table-markup
> org-inlinetask-show-first-star

This is now fixed in Org git repo, it will be part of the next merge.

Thanks,

-- 
 Bastien

bug#16270: Incorrect custom types

[Bastien]

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

> This refers to the version of Org mode in Emacs trunk.
> The following variables have incorrect custom types:

Fixed in Org repo.

> org-babel-lob-files

Not sure what's wrong with the one above.  Can you tell me?

Thanks,

-- 
 Bastien

bug#16270: Incorrect custom types

[Glenn Morris]

Bastien wrote:

>> org-babel-lob-files
>
> Not sure what's wrong with the one above.  Can you tell me?

emacs -Q -l ob-lob
M-x customize-variable RET org-babel-lob-files RET

    -> State: STANDARD. (mismatch)

The specification for a list custom object is as follows:

`(list ELEMENT-TYPES...)'
     The value must be a list with exactly as many elements as the
     ELEMENT-TYPES given; and each element must fit the corresponding
     ELEMENT-TYPE.

You cannot just write 'list.
Perhaps you wanted '(repeat file).

From the doc, it also sounds like this should have a :set function.
BTW, the first line of org-babel-lob-ingest's doc is not a complete
sentence.

bug#16270: Incorrect custom types

[Bastien]

Glenn Morris <rgm@gnu.org> writes:

> emacs -Q -l ob-lob
> M-x customize-variable RET org-babel-lob-files RET
>
>     -> State: STANDARD. (mismatch)
>
> The specification for a list custom object is as follows:
>
> `(list ELEMENT-TYPES...)'
>      The value must be a list with exactly as many elements as the
>      ELEMENT-TYPES given; and each element must fit the corresponding
>      ELEMENT-TYPE.
>
> You cannot just write 'list.
> Perhaps you wanted '(repeat file).

Indeed, fixed in Org's repo.

> From the doc, it also sounds like this should have a :set function.
> BTW, the first line of org-babel-lob-ingest's doc is not a complete
> sentence.

Ditto.

Thanks,

-- 
 Bastien

bug#16270: Incorrect custom types

[Bastien Guerry]

Bastien <bzg@gnu.org> writes:

> Indeed, fixed in Org's repo.

This is now in Emacs trunk.  Closing.