From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance Date: Mon, 17 Mar 2014 21:51:04 +0100 Message-ID: <87iorcpn0n.fsf@Rainer.invalid> References: <87bnx9qbcq.fsf@bzg.ath.cx> <87vbvcptqt.fsf@Rainer.invalid> <87ob14d4o7.fsf@bzg.ath.cx> <87r460pr8d.fsf@Rainer.invalid> <87ha6wd3hg.fsf@bzg.ath.cx> <87mwgoppvf.fsf@Rainer.invalid> <87mwgopnrf.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35444) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPeVI-0005ev-Su for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:51:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPeVC-0008JK-Nd for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:51:24 -0400 Received: from plane.gmane.org ([80.91.229.3]:50074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPeVC-0008JE-GW for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:51:18 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WPeV9-0002tA-Lr for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 21:51:15 +0100 Received: from pd9eb38c8.dip0.t-ipconnect.de ([217.235.56.200]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Mar 2014 21:51:15 +0100 Received: from Stromeko by pd9eb38c8.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Mar 2014 21:51:15 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien writes: > What I meant is this: broken tests are not a sufficient reason to > revert a commit. You need to show the commit is wrong and the tests > are not outdated. No code breaking a test should have been committed in the first place, then we wouldn't need to have this discussion. If the "tests are outdated" (in this case they ensure that the documentation and implementation are matching up which is difficult to ascertain by just playing with a single example, so that shouldn't ever happen), the onus is on the committer to explain why and change the tests and documentation accordingly (either as a preparation for that commit or in the same commit). Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf Blofeld V1.15B11: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada