From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] No title in org-export-as-odt Date: Wed, 16 Apr 2014 16:38:49 +0200 Message-ID: <87ioq9z0bs.fsf@bzg.ath.cx> References: <1348466593.45471.YahooMailClassic@web133101.mail.ir2.yahoo.com> <8761p5empk.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaT1l-0000Dp-CZ for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WaT1f-0008FU-IH for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:37 -0400 Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:62431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaT1f-0008FI-BH for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:31 -0400 Received: by mail-we0-f173.google.com with SMTP id w61so10944571wes.4 for ; Wed, 16 Apr 2014 09:49:30 -0700 (PDT) In-Reply-To: (Brady Trainor's message of "Fri, 28 Mar 2014 06:05:32 +0000 (UTC)") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Brady Trainor Cc: emacs-orgmode@gnu.org Hi Brady, Brady Trainor writes: > I wanted to return to this and attempt it, here is my first patch ever: Thanks, > diff --git a/lisp/ox-odt.el b/lisp/ox-odt.el > index da2ca3f..8c7f0fe 100644 > --- a/lisp/ox-odt.el > +++ b/lisp/ox-odt.el > @@ -1491,7 +1491,7 @@ original parsed data. INFO is a plist holding export > options." > (goto-char (match-beginning 0)) > > ;; Preamble - Title, Author, Date etc. > - (insert > + (ignore > (let* ((title (org-export-data (plist-get info :title) info)) > (author (and (plist-get info :with-author) > (let ((auth (plist-get info :author))) The way not to insert a title is simply to add an empty title like this: #+TITLE: Otherwise, Org falls back on the file name. > I installed a fresh version of org-mode from Elpa or Melpa before doing > this. (I am just now looking a little into the maint branch.) > > In the long-long run, when I go to insert the code, I wonder why we don't > make removing the title an option in ox.el. This could be done with a new `org-export-with-title' option but I would rather stick to the current way of doing it (an empty value for #+TITLE:). Thanks anyway for the patches, -- Bastien