From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: ob-lilypond code cleanup Date: Mon, 18 Aug 2014 13:17:10 +0200 Message-ID: <87iolqm4i1.fsf@nicolasgoaziou.fr> References: <87iolr8m0f.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJKvW-0005ub-Bz for emacs-orgmode@gnu.org; Mon, 18 Aug 2014 07:16:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJKvP-0008Tu-4I for emacs-orgmode@gnu.org; Mon, 18 Aug 2014 07:16:38 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:44288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJKvO-0008Sf-UX for emacs-orgmode@gnu.org; Mon, 18 Aug 2014 07:16:31 -0400 In-Reply-To: <87iolr8m0f.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 17 Aug 2014 12:10:24 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hello, Achim Gratz writes: > Triggered by the discussion about it, I've looked at ob-lilypond and > found that it should be cleaned up a bit. The defvars holding the > various commands should really be defcustoms, but I've ran out of time > for now. If anybody thinks this should go to maint please say so, > otherwise I will commit on master. FWIW, I think prefix conformance should go to maint. Also, you shouldn't use `pcase' as Org preserves compatibility with Emacs 23. Regards, -- Nicolas Goaziou