emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: [bisected] note from clocking out is above :LOGBOOK: drawer [8.3.3 (release_8.3.3-469-g2e7716 @ /home/grfz/src/org-mode/lisp/)]
Date: Wed, 20 Jan 2016 14:32:09 +0100	[thread overview]
Message-ID: <87io2ogyw6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87bn8hmv6n.fsf@len.workgroup> (Gregor Zattler's message of "Tue, 19 Jan 2016 16:43:28 +0100")

Hello,

Gregor Zattler <telegraph@gmx.net> writes:

> Notes produced when clocking out with org-log-note-clock-out set
> will be placed above the clock line instead below the clock line.
> In my heavily customized sessions the notes show up on the
> previos line respective to the clock line.  Without
> customizations (see below) they end up above the :LOGBOOK:
> drawer.
>
> ECM:
> emacs24 -Q -nw -L /home/grfz/src/org-mode/lisp/ --eval "(require 'org)"  --eval '(setq org-log-note-clock-out t)' /tmp/test.org
>
> now add a heading, clock in, clock out, write something as a note,
> do C-c C-c to finish note taking.  Result:
>
> * heading
>   - note
>   :LOGBOOK:
>   CLOCK: [2016-01-19 Di 16:22]--[2016-01-19 Di 16:22] =>  0:00
>   :END:

I can reproduce it. However, I don't think it is a bug. It looks like
the expected default behaviour.

By default, clocks and notes are not stored at the same location. See
`org-log-into-drawer' and `org-clock-into-drawer'. So, there's no reason
to put them together here. 

Moreover, I cannot see anything in the code that would make "clock
notes" special in any way. This is basically the same as calling
`org-add-note' right after clocking out, and, as this function's
docstring points out:

  This is done in the same way as adding a state change note.

OTOH, the manual says

  See the variable ‘org-log-note-clock-out’ for the possibility to
  record an additional note together with the clock-out timestamp.

In particular, the term "together" is ambiguous, as it can indeed be
understood as "at the same place". However, I doubt the intent is to
create a new type of note that would purposely ignore global logging
settings. So I lean towards a documentation bug here.

WDYT?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-01-20 13:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 15:43 Bug: [bisected] note from clocking out is above :LOGBOOK: drawer [8.3.3 (release_8.3.3-469-g2e7716 @ /home/grfz/src/org-mode/lisp/)] Gregor Zattler
2016-01-20 13:32 ` Nicolas Goaziou [this message]
2016-01-20 14:58   ` Gregor Zattler
2016-01-20 15:57     ` Nicolas Goaziou
2016-01-21  1:38       ` Gregor Zattler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io2ogyw6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).