emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: John J Foerch <jjfoerch@earthlink.net>
To: emacs-orgmode@gnu.org
Subject: Re: org-attach-commit optional
Date: Thu, 11 Feb 2016 10:46:39 -0500	[thread overview]
Message-ID: <87io1vs10g.fsf@hecubus.retroj.net> (raw)
In-Reply-To: 87io1vy5ob.fsf@nicolasgoaziou.fr

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> John J Foerch <jjfoerch@earthlink.net> writes:
>
>> I would like for org-attach's automatic committing of attachments to be
>> easily disabled.  Something along the lines of the attached patch.
>> Thoughts?
>
> Thank you. A few stylistic comments follow.
>
>> Subject: [PATCH] org-attach-attach: make use of git optional with variable
>>  org-attach-commit
>
> The commit message should be something along the lines:
>
>   org-attach: Optionally make use of git
>
> * lisp/org-attach.el (org-attach-commit): New variable.
> (org-attach-attach): Use new variable.
>
> You also need to add TINYCHANGE at the end of the commit message. On
> this topic, please not that you are, with this patch, reaching the limit
> of allowed changes without FSF assignment. You may want to consider
> signing FSF papers.
>
>> +(defcustom org-attach-commit t
>> +  "If non-nil, attachments will be committed with git, if the org
>> +file is in a git repository."
>> +  :group 'org-attach
>> +  :type 'boolean)
>
> First line in docstring should be a sentence on its own, e.g.
>
>     "Non-nil means attachements are to be committed with git.
>   This can only happen if the Org file is in a git repository."
>
> You should also add :version and :package-version keywords, e.g.,
>
>   :version "25.1"
>   :package-version '(Org . "9.0")
>
>
> Regards,

Many thanks, Nicolas,

I would be glad to do the paperwork, but as it's such a simple change, I
have no objections to anybody else implementing this feature request in
my place if they want to.  I think it would save time.  Need not use the
patch I sent, which needs revision anyway - it was just a suggested
implementation.  Let me know if this works for this community, or
whether it is preferred for me to go through the FSF process.

Thank you,

John Foerch

  reply	other threads:[~2016-02-11 15:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 22:39 org-attach-commit optional John J Foerch
2016-02-11  9:09 ` Nicolas Goaziou
2016-02-11 15:46   ` John J Foerch [this message]
2016-02-11 17:29     ` Nicolas Goaziou
2016-02-11 18:32       ` John J Foerch
2016-02-14 16:57         ` Nicolas Goaziou
2016-02-14 17:09           ` John J Foerch
2016-02-11  9:16 ` Marco Wahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io1vs10g.fsf@hecubus.retroj.net \
    --to=jjfoerch@earthlink.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).