From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Make lexical eval default for elisp src blocks
Date: Mon, 18 Apr 2016 18:38:43 +0200 [thread overview]
Message-ID: <87inzeeuss.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1460855140-36680-1-git-send-email-jkitchin@andrew.cmu.edu> (John Kitchin's message of "Sat, 16 Apr 2016 21:05:40 -0400")
Hello,
John Kitchin <jkitchin@andrew.cmu.edu> writes:
> Set default in `org-babel-default-header-args:emacs-lisp'. Add an
> optional argument to the eval function.
Thanks for the patch. Some comments follow.
> +*** Default lexical evaluation of emacs-lisp src blocks
> +Emacs-lisp src blocks in babel are now evaluated using lexical scoping. There is a new header to control this behavior.
> +
> +The default results in an eval with lexical scoping.
> +:lexical yes
> +
> +This turns lexical scoping off in the eval (the former behavior).
> +:lexical no
> +
> +This uses the lexical environment with x=42 in the eval.
> +:lexical '((x . 42))
According to the Elisp manual:
The value of LEXICAL can also be a non-empty alist specifying
a particular "lexical environment" for lexical bindings; however,
this feature is only useful for specialized purposes, such as in
Emacs Lisp debuggers. *Note Lexical Binding::.
I'm not opposed to it, but is there any reason to include the
opportunity to specify an alist here?
> +(defvar org-babel-default-header-args:emacs-lisp
> + '((:lexical . "yes"))
> + "Default arguments for evaluating an emacs-lisp source block.
> +
> +:lexical is \"yes\" by default and causes src blocks to be eval'd
> +using lexical scoping. It can also be an alist mapping symbols to
> +their value. It is used as the optional LEXICAL argument to
> +`eval'.")
You need to separate sentences with two spaces.
You also need to add (defconst org-babel-header-args:emacs-lisp). See
for example `org-babel-header-args:R'.
> (defun org-babel-expand-body:emacs-lisp (body params)
> "Expand BODY according to PARAMS, return the expanded body."
> @@ -51,13 +57,18 @@
> (defun org-babel-execute:emacs-lisp (body params)
> "Execute a block of emacs-lisp code with Babel."
> (save-window-excursion
> - (let ((result
> - (eval (read (format (if (member "output"
> - (cdr (assoc :result-params params)))
> - "(with-output-to-string %s)"
> - "(progn %s)")
> - (org-babel-expand-body:emacs-lisp
> - body params))))))
> + (let* ((lexical (cdr (assoc :lexical params)))
Nitpick: (cdr (assq :lexical params))
> + (result
> + (eval (read (format (if (member "output"
> + (cdr (assoc :result-params params)))
Nitpick, while you're at it: (cdr (assq :result-params params))
> + "(with-output-to-string %s)"
> + "(progn %s)")
> + (org-babel-expand-body:emacs-lisp
> + body params)))
> +
> + (if (listp lexical)
> + lexical
> + (string= "yes" lexical)))))
There is no support for t. I think we should allow both :lexical
t and :lexical yes.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2016-04-18 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 1:05 [PATCH] Make lexical eval default for elisp src blocks John Kitchin
2016-04-17 23:47 ` Adam Porter
2016-04-18 15:44 ` John Kitchin
2016-04-18 16:38 ` Nicolas Goaziou [this message]
2016-04-18 17:09 ` John Kitchin
2016-04-18 17:41 ` Nicolas Goaziou
2016-04-18 17:56 ` John Kitchin
-- strict thread matches above, loose matches on Subject: below --
2016-04-18 17:55 John Kitchin
2016-04-20 8:19 ` Nicolas Goaziou
2016-04-20 12:34 ` John Kitchin
2016-04-20 21:47 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inzeeuss.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jkitchin@andrew.cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).