emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* About org-sort -> org-sort-list with custom sort function
@ 2017-05-03 19:36 Zhitao Gong
  2017-05-07  2:55 ` Kyle Meyer
  0 siblings, 1 reply; 21+ messages in thread
From: Zhitao Gong @ 2017-05-03 19:36 UTC (permalink / raw)
  To: emacs-orgmode

Hi All,

I think there is a bug in org-sort or org-sort-list function.

If you call org-sort (C-c ^) on list items, this function will call
org-sort-list.  However, org-sort calls org-sort-list with only one
argument, i.e., the with-case (see the code below)

#+BEGIN_SRC emacs-lisp
((org-at-item-p) (org-call-with-arg 'org-sort-list with-case))
#+END_SRC emacs-lisp

The problem is that if you choose ?f (sorting with custom key function),
then org-sort-list expects another argument, the compare-func, which is
not passed to it.

IMHO, there are two ways to solve this

1. Ask for the compare-func in org-sort-list, as it does for the
   getkey-func.  A default value could be provided for compare-func,
   e.g., string<, <, etc.  Or
2. Restrict the return type to a string (or integer) so that we could
   fix the compare-func

-- 
gongzhitaao / 半緣脩道半緣君

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2017-05-17 12:33 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-03 19:36 About org-sort -> org-sort-list with custom sort function Zhitao Gong
2017-05-07  2:55 ` Kyle Meyer
2017-05-07 10:00   ` Nicolas Goaziou
2017-05-07 14:20     ` Kyle Meyer
2017-05-07 15:37       ` Kyle Meyer
2017-05-08  9:48         ` Nicolas Goaziou
2017-05-08 15:24           ` Kyle Meyer
2017-05-08 16:23             ` Nicolas Goaziou
2017-05-08 16:45               ` Kyle Meyer
2017-05-08 16:48                 ` Nicolas Goaziou
2017-05-09 19:47                 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47                   ` Nicolas Goaziou
2017-05-12  1:48                     ` Kyle Meyer
2017-05-12  7:10                       ` Nicolas Goaziou
2017-05-13 14:50                         ` [PATCH v2] " Kyle Meyer
2017-05-14  8:24                           ` Nicolas Goaziou
2017-05-14 13:45                             ` Kyle Meyer
2017-05-14 16:51                               ` Nicolas Goaziou
2017-05-14 20:54                                 ` Kyle Meyer
2017-05-17 12:32                                   ` Nicolas Goaziou
2017-05-09  4:10             ` About org-sort -> org-sort-list with custom sort function Kyle Meyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).