emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thomas Cordival <thomas@tuxella.me>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add minlevel parameter to column view parameters
Date: Thu, 19 Oct 2017 21:33:42 +0200	[thread overview]
Message-ID: <87infbszjd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2shei9d07.fsf@tuxella.me> (Thomas Cordival's message of "Tue, 17 Oct 2017 14:26:16 +0200")

Hello,

Thomas Cordival <thomas@tuxella.me> writes:

> you will find attached a simple patch to add a new parameter to the
> column view dynamic block: minlevel.

Thank you!

> +     (if (and minlevel maxlevel)
> +	 (format "LEVEL>=%d&LEVEL<=%d" minlevel maxlevel)
> +       (if minlevel
> +	   (format "LEVEL>=%d" minlevel)
> +	 (if maxlevel
> +	     (format "LEVEL<=%d" maxlevel))
> +	 ))

This could be refactored into a `cond'.

> +     ;; (and (or (not minlevel) (format "LEVEL>=%d" minlevel))
> +     ;; 	  (or (not maxlevel) (format "LEVEL<=%d" maxlevel)))

This can be removed.

Have you signed FSF papers? Otherwise, you need to insert TINCHANGE at
the end of the commit message.


Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2017-10-19 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 12:26 Add minlevel parameter to column view parameters Thomas Cordival
2017-10-19 19:33 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87infbszjd.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=thomas@tuxella.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).