From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] fix org-num-mode detect enabled already issue Date: Mon, 07 Jan 2019 14:07:26 +0800 Message-ID: <87imz1dmqp.fsf@gmail.com> References: <875zv35iec.fsf@gmail.com> <871s5pe4d2.fsf@nicolasgoaziou.fr> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:38822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggO2x-0004wm-8f for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 01:06:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggO2w-0005AB-1G for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 01:05:59 -0500 Received: from [61.175.244.13] (port=14652 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggO2v-0004rg-H8 for emacs-orgmode@gnu.org; Mon, 07 Jan 2019 01:05:57 -0500 In-reply-to: <871s5pe4d2.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: org-mode I fixed my previous patch which work in reverse direction. modified lisp/org-num.el @@ -438,17 +438,16 @@ NUMBERING is a list of numbers." (define-minor-mode org-num-mode "Dynamic numbering of headlines in an Org buffer." :lighter " o#" - (cond - (org-num-mode - (unless (derived-mode-p 'org-mode) - (user-error "Cannot activate headline numbering outside Org mode")) - (setq org-num--numbering nil) - (setq org-num--overlays (nreverse (org-num--number-region nil nil))) - (add-hook 'after-change-functions #'org-num--verify nil t)) - (t + (if org-num-mode + (progn + (unless (derived-mode-p 'org-mode) + (user-error "Cannot activate headline numbering outside Org mode")) + (setq org-num--numbering nil) + (setq org-num--overlays (nreverse (org-num--number-region nil nil))) + (add-hook 'after-change-functions #'org-num--verify nil t)) (mapc #'delete-overlay org-num--overlays) (setq org-num--overlays nil) - (remove-hook 'after-change-functions #'org-num--verify t)))) + (remove-hook 'after-change-functions #'org-num--verify t))) -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3