From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH] Fix several issues with python session value blocks
Date: Thu, 23 Jan 2020 05:24:36 +0000
Message-ID: <87iml2agob.fsf@kyleam.com>
References: <87pnfdo88v.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41751)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kyle@kyleam.com>) id 1iuUyy-0003YK-9s
 for emacs-orgmode@gnu.org; Thu, 23 Jan 2020 00:24:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kyle@kyleam.com>) id 1iuUyx-000188-7b
 for emacs-orgmode@gnu.org; Thu, 23 Jan 2020 00:24:44 -0500
Received: from pb-smtp20.pobox.com ([173.228.157.52]:57723)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1iuUyw-00016K-Nt
 for emacs-orgmode@gnu.org; Thu, 23 Jan 2020 00:24:43 -0500
In-Reply-To: <87pnfdo88v.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Jack Kamm <jackkamm@gmail.com>, emacs-orgmode@gnu.org

Jack Kamm <jackkamm@gmail.com> writes:

> This patch fixes several related issues with python blocks with
> parameters ":session :results value", including:
>
> - Broken if-else and try-except statements.
> - Correctly parsing blank lines in indented blocks.
> - Returning the correct value when the underscore "_" variable
>   has been assigned.
> [...]
> There is some useful background and discussion of the issues here:
>
> https://lists.gnu.org/archive/html/emacs-orgmode/2017-11/msg00274.html
>
> In that thread from 2017, we solved similar problems for the ":results
> output" case. With this patch, I'm now circling back to try and fix the
> ":results value" case.

Thanks!  I'll plan to take a deeper look within the next week.  However,
given that I'm not an ob-python user (or a much of a babel user in
general), I hope those who are will try out your patch and give
feedback.