Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

[stardiviner <numbchild@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Bastien <bzg@gnu.org> writes:

> Hi stardiviner,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> I tested your method, true. And I also pulled that latest ob-clojure.el changes.
>> Works great, I like this new method more. Thanks for your
>> improvement.
>
> Thanks for your feedback.
>
> Also, you may have noted that the code for Clojure sessions has been
> removed - I could not make it work, even in previous versions.

Yes, I always check related changes on Org Mode master branch source code.

>
> If you know sesman/cider better than I do and can propose to handle
> sesman/cider sessions correctly, please go ahead.
>
> By "correctly" I mean requesting the launch of a (sibling?) nREPL
> process buffer when :session is set to a string.

Actually I'm not very familiar with CIDER, but I want to take a try. :)

>
>> The clojurescript support has a ~:target~ header argument to tell CIDER this is a
>> clojurescript code, I don't know CIDER internal much, but CIDER eval should eval
>> in a ClojureScript corresponding REPL.
>
> Yes, what I meant was that for now ":target cljs" won't let you start
> a nREPL unless you are in a ClojureScript project.
>
> cider-jack-in-cljs will ask for the cljs method (figwheel-main, etc.)
> but if your org file is in, e.g., an empty directory, there is no such
> cljs configuration file.

I agree.

- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5NWYoUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsNpkggAtMIWaYdp6nJrNw820X8BZaL4luW4
hZeBf7YJaomopWZK5ToGquGMVTCsPuvxKtSBwlM00WEaklDfmDN6C50aqDvyVesk
E+emQ4rF8a2A0LfvUw4CwoRLaqoa9gJUzGzwWFuz//HY8DHkl2n2jbTaLDLuzlOT
laAFODwzGHbJlm/MFayKds+jLMLP95F5D+6G6ZPKitfnfyurAwp9OGnI9G63w9Ye
LVD0Yqcr3jLUgHJfSSaUAny8DV9DOlvaVez1AZQosc//PER5DqxXHeMhaLMSNEGB
RI7W6ufOfSRT0L4gQ3H9W4X34Kt28+Aoj2wGvx2q4niI9pxEkW1kLzpF2w==
=LNjE
-----END PGP SIGNATURE-----