From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eOnkDi3AF18VCgAA0tVLHw (envelope-from ) for ; Wed, 22 Jul 2020 04:27:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KGrHCi3AF1+jEgAAB5/wlQ (envelope-from ) for ; Wed, 22 Jul 2020 04:27:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 129CE9403C6 for ; Wed, 22 Jul 2020 04:27:24 +0000 (UTC) Received: from localhost ([::1]:58564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jy6Lh-0005Tj-BZ for larch@yhetil.org; Wed, 22 Jul 2020 00:27:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy6L7-0005Rq-SX for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 00:26:45 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:59035) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jy6L5-0000I1-TF for emacs-orgmode@gnu.org; Wed, 22 Jul 2020 00:26:45 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 88FABED88F; Wed, 22 Jul 2020 00:26:40 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:date:message-id:mime-version:content-type; s=sasl; bh=0prPMZvnTd2gAav8/35FxH8M1iU=; b=TYJc1jczmdqAQvTqutrw uc6qY11pDArIcnwNYmu8saO7SdKGwtdHWt2ddNSC3dKSTpghnjyzzifpV5dY+Jf5 X35WgV4WO7XhUglr51HjqS0juRTkcdodovdJ0RmbrRB2pclr75lAuRPRdLVPCQSH ngvo78tUgZTQXu/tZ2ggiYY= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 81CD2ED88E; Wed, 22 Jul 2020 00:26:40 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:date:message-id:mime-version:content-type; s=mesmtp; bh=d/t8WKXjg8mTLzswuNL6kHaqGKScip1B6TbfckCbzU4=; b=FqWm5/cfF9mtjjfHis1KSVViuzXj0ceJnrAjvZtrF6b1nCp3T0/cpteUFYTsX4RkUf4y5YIrQep6m1vY/568E+upPc7fWjrSZBrVujR3z6aA4xQG264tSdufNyGM4JSM9kppM+Z9t9wPnSZHMvJK3aoPjjR2Z19ZF5TD1UaoIRE= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 04D63ED88D; Wed, 22 Jul 2020 00:26:37 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Clemens Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command In-Reply-To: Date: Wed, 22 Jul 2020 00:26:36 -0400 Message-ID: <87imegyy2r.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 88B54EF6-CBD3-11EA-942C-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 00:20:01 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=TYJc1jcz; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=FqWm5/cf; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: 8wiHJEKwtUdb Clemens writes: > My patch aims to get you completion with the default completion and also > for any framework that complies to it out of the box. Without my patch > (and without helm-org) you don't get completion after the first tag I think. With the built-in completion, org-set-tags-command already supports completing multiple tags. So that aim reduces to using completing-read-multiple because other completion libraries are more likely to play nicely with crm. At the moment that's not mentioned in the commit message (and, less importantly, it wasn't mentioned in the message introducing the patch), but in my view that aim should be the emphasis of the commit message. It'd be good to note the popular completion libraries that don't work out of the box with the current approach, and whether they do after this patch. It's also probably worth mentioning why org-tags-completion-function is still passed as the completion function to completing-read-multiple, as the completion function's main purpose of completing multiple tags could now be fulfilled by completing-read-multiple alone. And what about the other spots that use org-tags-completion-function? Thanks.