From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gI1rJ0F2cV8YKAAA0tVLHw (envelope-from ) for ; Mon, 28 Sep 2020 05:36:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GAZQI0F2cV8TNgAAB5/wlQ (envelope-from ) for ; Mon, 28 Sep 2020 05:36:01 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8DA869402B2 for ; Mon, 28 Sep 2020 05:36:00 +0000 (UTC) Received: from localhost ([::1]:42758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMlpO-0005MR-9r for larch@yhetil.org; Mon, 28 Sep 2020 01:35:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMlp1-0005M8-2g for emacs-orgmode@gnu.org; Mon, 28 Sep 2020 01:35:35 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:40502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMloz-0001tJ-81; Mon, 28 Sep 2020 01:35:34 -0400 Received: by mail-pf1-x442.google.com with SMTP id x123so8321519pfc.7; Sun, 27 Sep 2020 22:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=GlPU+R2fTralN18UuFJSlKMmt26Lp9PmExWdVkGgFKc=; b=nRnHMJvQ71Nj5xkKp1J1WJQmAtyo2deiYn+xSq4Xsmfyrr2rHHLuyvm3ozQ3rC5ZdY LjvluiQFpOOYGmrYQ57CwUcT731xYfPQ1Rz/1JZ4+4ekZB9dyoh9adi26mK6oJI0b3fm zCfe5iFfw4d/WARwnAcmryfYm6GE/c7tGfsorIPlN5/RTZfisGaEZueFcmc0wPn3tA5C VdngzlLNMmrduuC6tV+FFqKEJq1PxUB4LoZ7512dLQgTKfMbnfqPCBfag+h6RRC4N3o7 FRHh2Yvwj42k8ideZNb4CtWuoZQq/5sB89hmQpssDYcWYWVHxP8mH1V6ejYrNv31aTi3 iSbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=GlPU+R2fTralN18UuFJSlKMmt26Lp9PmExWdVkGgFKc=; b=XHmnfgdmO6rmtQ6QTAxVppNdZrGWRcOGpAtTNnCjSG8nBfqzkV7duEhQVv4zwB5Bh+ x8uec0bZAx3uwlF7iCp8wUQEzFSbakZsl7jFgVnjPKWEDU3YHszqIKimlVcZrjSNK26E VkLdh+8P2my4llgGwGc+1YmPpKAthsIecasemY+LNrdxNMdRjFZIqcD2omIRJidgT4hw 1SXIeUnZ90f/kBc9GYRJ346F4iWBJfkLbda9z6Ei9JIcAifsLZD1kRjcsXd2dvQBQNTP TeBJjY3y+skSOgkAhh0RNWYq6jgXvGyS9xk71hzZ2VEHiYu75tDiMb0inj9BUlOs/gmQ yIlA== X-Gm-Message-State: AOAM530rjiRkkk8nDhqy7FlVYUq/MXWwMAArBzx+09+l0zVUQRKQjrtZ g04kKvfFOBeyB4x7BPX5DqE= X-Google-Smtp-Source: ABdhPJxgy5oHjdDApeWryDq+vp5CfnEcWavN9/HGwaYSEShHF4uK5l2Md6DivoBbQTMU+znabzC+zQ== X-Received: by 2002:a63:8f18:: with SMTP id n24mr1804509pgd.209.1601271330979; Sun, 27 Sep 2020 22:35:30 -0700 (PDT) Received: from localhost ([104.250.131.79]) by smtp.gmail.com with ESMTPSA id fu11sm5553075pjb.47.2020.09.27.22.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 22:35:30 -0700 (PDT) From: Ihor Radchenko To: Kyle Meyer Subject: Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)] In-Reply-To: <87tuviqyi4.fsf@kyleam.com> References: <50f165b2-bdaf-4861-aab5-122cfef7d67c@www.fastmail.com> <5f6aa2e2.1c69fb81.9bff7.9127@mx.google.com> <87k0wkheik.fsf@gnu.org> <87lfh060pb.fsf@localhost> <87tuviqyi4.fsf@kyleam.com> Date: Mon, 28 Sep 2020 13:34:24 +0800 Message-ID: <87imby1n33.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=yantar92@gmail.com; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: B Goodr , Dmitrii Korobeinikov , Bastien , emacs-orgmode@gnu.org, Nicholas Savage Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=nRnHMJvQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.59 X-TUID: juC553h0Vd6A > Did you intended to send a different patch? This looks to be the same > patch you sent at . I have no patch for the bug report in this thread. The patch I sent was intended for https://orgmode.org/list/87ft78608z.fsf@localhost. > But, trying with the current master (16f505db2), tab still doesn't > fold that heading on my end. Same on my end. Best, Ihor Kyle Meyer writes: > Ihor Radchenko writes: > >> Subject: [PATCH] Do not remove trailing newline when deleting planning info >> line. >> >> * lisp/org.el (org-add-planning-info): Remove front newline instead of >> trailing newline when deleting planning info is completetly removed >> from a heading. Fixes "Cycling through TODO workflow joins the next >> line onto the current one". > > Did you intended to send a different patch? This looks to be the same > patch you sent at . > > Also, can someone could provide an example case that was fixed by > ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)? > The report that prompted that commit didn't include one: > https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com > > I tried with > > --8<---------------cut here---------------start------------->8--- > > * TODO a > > * TODO b > --8<---------------cut here---------------end--------------->8--- > > If I understand the original message by Dmitrii (+cc), the request was > that, since starting up folded shows the first heading as > > * TODO a... > > tab should be able to fold the heading back to that state after > expansion. But, trying with the current master (16f505db2), tab still > doesn't fold that heading on my end. Unless we have a concrete reason > to keep ee3c3b554, reverting it might be the best fix for this thread's > issue.