From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wAIpFLKAUWB3fAAA0tVLHw (envelope-from ) for ; Wed, 17 Mar 2021 04:08:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mJX5D7KAUWDYLQAAB5/wlQ (envelope-from ) for ; Wed, 17 Mar 2021 04:08:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7986F275E6 for ; Wed, 17 Mar 2021 05:08:17 +0100 (CET) Received: from localhost ([::1]:58690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMNTi-00034E-Ux for larch@yhetil.org; Wed, 17 Mar 2021 00:08:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNT6-000347-Fo for emacs-orgmode@gnu.org; Wed, 17 Mar 2021 00:07:36 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:31317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMNT2-0003iD-0B for emacs-orgmode@gnu.org; Wed, 17 Mar 2021 00:07:36 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1615954048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CwSRveghgzhn6Fss5nvGSC9MHJjpx2BTQGYpyWASqIs=; b=ZF6GP2pIpuBTK9+qq7U2Gep7i5aEroTKa4LU5S37W85efJoDMIuR2Ps3TmkgLK1CJqFkS3 HOKFxPr1ROCmrEOuicEyXC/foUxrfmbybX8RXwYmULtWmRu1mwKiz7grg7nYCDfWM5SAtw 8QKY219+KnIBOG17M9EgLm1MQtYXveL7yzcgBrnxQyjK0caT+2T1kg2Uq10SnLnTJqAac6 8FelZFAvmC1/dFGnGojz+pggyneinfCiAXUW8XLT7CvGa0vt3juqONQ1DNwlKYOrphOuw3 6sLm+UcAR5Jxh9MOxhVJJCA6VznjN8G3RwJUNkJHzarZ40QXin687mF4kdVhfg== From: Kyle Meyer To: Robin Campbell Joy Subject: Re: [PATCH] ob-sql.el: Add support for SAP HANA In-Reply-To: References: <87lfaniu8k.fsf@kyleam.com> X-Woof-Patch: applied Date: Wed, 17 Mar 2021 00:07:21 -0400 Message-ID: <87im5qift2.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615954097; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CwSRveghgzhn6Fss5nvGSC9MHJjpx2BTQGYpyWASqIs=; b=QscXdhEwFxKKUu91kdDFvK1jRNiNi2iTbuIJw8t3PT9lWVnCFvGJ554003obbkwq5O6xhh hk0YnMJVB5jJFYJS6kWWtL5kRIk9xyh5m3wi1eBdFuRnKJxiW0iRJnCYsx2bTFVgBMqPnQ a1titIeThXYiv+/gHFMTkTrdUmsYlNBPgzlS7dOP4HqSrMq7e6nXx1yJfn8d6DBasUoZaW kiYZKsz55WH4RQdzHmz01jwYKYmgmDwbbgu7RpQuen7m/9fnncyp2eUYfrBLrQmlOpTRLh 29jI7mltm3P4OIe0OuJ7Bgvff0n1Tkns0ix32PoL26FVIm5Bc6qBLBw81a6g+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615954097; a=rsa-sha256; cv=none; b=Me0dbXtQeoUY54bmiYD86Zgvnet1fT25rkMBtnNI9LPIQrLQ98t1dHrYxl3iP530hBDM84 Zi/X6O9nUKjCc43AKGizcwtLiOVWIG4hnKXatEVq8EW7YL7RjA0l9iXUHBc/5fWBuRmE5d FIgV2OTeIdw4fmR/tEp2QYZjFuEU7fASRLlObclBIkPFwyAvviRGIYIt4p/rpUS56S+ugh BJ239g03sl6lkrLVBLL5M7IFt6urDxGA81N9X4jjmI9enkNK37GyMH5mGYSTjnBuJRG8je 2yTlYFY7VuOgs+Gr+Kul4eJYvMcPhwcE2y0t3ii6dQnHzjtyhvqH9fElmtm95w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=ZF6GP2pI; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.60 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=ZF6GP2pI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7986F275E6 X-Spam-Score: -2.60 X-Migadu-Scanner: scn0.migadu.com X-TUID: BgEdBMcCA1df Robin Campbell Joy writes: > Subject: [PATCH] ob-sql.el: Add support for SAP HANA Thanks for the update. Pushed (b241c126b). > diff --git a/testing/lisp/test-ob-sql.el b/testing/lisp/test-ob-sql.el [...] > + > +(require 'org-test) > +(require 'ob-sql) I've dropped these two lines. For the first one, currently only four test files load org-test explicitly, while the majority of the tests rely on org-test being loaded as part of the setup. For the second, nearly all ob-LANG tests check whether the corresponding ob- feature is available, signaling missing-test-dependency if it's not. Which ob- libraries are loaded/tested can then controlled by the Makefile variable BTEST_OB_LANGUAGES. Explicitly loading the ob- file goes against that setup, making the (featurep ...) check that follows always return non-nil, I'm guessing this line was adjusted from test-ob-sqlite, which appears to be the one [*] ob-LANG test file that gets this wrong. I've pushed another commit to adjust it. [*] I believe ob-emacs-lisp is an intended exception. > +(unless (featurep 'ob-sql) > + (signal 'missing-test-dependency "Support for sql code blocks"))