From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CJboDz8y3mC99wAAgWs5BA (envelope-from ) for ; Thu, 01 Jul 2021 23:23:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yGObCz8y3mBOIQAA1q6Kng (envelope-from ) for ; Thu, 01 Jul 2021 21:23:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3ABA31B307 for ; Thu, 1 Jul 2021 23:23:10 +0200 (CEST) Received: from localhost ([::1]:47568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz49M-0005JS-6M for larch@yhetil.org; Thu, 01 Jul 2021 17:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz48b-0005GY-MV for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 17:22:21 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:53905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz48Z-0001KM-IP for emacs-orgmode@gnu.org; Thu, 01 Jul 2021 17:22:21 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 072F5240007; Thu, 1 Jul 2021 21:22:15 +0000 (UTC) From: Nicolas Goaziou To: Timothy Subject: Re: [PATCH] Customizify org-babel-fortran-compiler References: <878s2qhzc1.fsf@gmail.com> Date: Thu, 01 Jul 2021 23:22:14 +0200 In-Reply-To: <878s2qhzc1.fsf@gmail.com> (Timothy's message of "Thu, 01 Jul 2021 22:40:30 +0800") Message-ID: <87im1twwzd.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.230; envelope-from=mail@nicolasgoaziou.fr; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nico Sonack , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625174590; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=WlrLetS33wT8qY8Vd/dW2WFa+dZ7fB1Tn6mphQeDwxo=; b=l5ltjyBrAyfl6zluqJaNkZPmAHKjL4UxWQlKJkISVm8m99nopg58mGWCEtRs9VCRecw0Zs mV6fs8EhXVOMNOAHP/2OumpWzGM+cqio/udWuFkJDtWfXYLYqV0bCZnO49xEkNmH1QKeDx 7rvqNGOncYBFVLT45Mdv7iixI8MIY3FvP4Loqzv99aomV5PhRg3sKC0OZB6G5+XklM3I2g QT7MgXpORWYSkaK9iFN6FzU5Gy2NSkbHuTQZOOqdypnro/soOJlv/8YLk2ccZNzRuHwZAp jkAfQxC1mevYgVBQuZ0DQfsGToE649XzOE7JwfktjuI9jHuoYg2gFUh+m4Nklg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625174590; a=rsa-sha256; cv=none; b=G2T7SA21gulXasqlHFyCtZbSAnOh5eiX7Kx75dpueJ9BOs+lqPLXh/B8AVjDeyiiGot/7F /jUkJrQh9XvqJRqq8q11CMVZ45j5DhXAYb8rJPxsTjTXF40sb0PzLkJh+B6LEonLihgEs9 9e5Rvr/uaB7HFs3G36uFu3ZAGoMDPtksUMfA1cC5YB6Fb7rzP4xXJw6v873bjcN0T9xfBZ 6OURT8SVj4mUrKPLXHXg8swOxFQIHQHottmFNytKYUpRz5wERsN5d3rXNKMYNMmJOdEHbE +syvYvaTLtzMbsK5mK9Rjz1Ierges0071s6GIC7J4xLWP+A6vcjfTO0i+HfnVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 3ABA31B307 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: OM472puyDLP2 Hello, Timothy writes: > Thanks for sending in the patch. Seeing it pointed out, this seems like > a pretty obvious omission. This looks like it should be pretty easy to > merge :) > > Four minor niggles with your commit message: > + Since `defvar' and `defcustom' are elisp symbols, they should be > quoted as such. > + It's probably better to avoid shorthand like "X -> Y", and write out > "Change X to Y" instead. > + You have included "lisp/" in the commit subject, which isn't needed. > Just "ob-fortran.el" or even "ob-fortran" is enough here. > + Your commit subject goes over 50 chars, which is undesirable. > > Here's what I'd recommend: > > #+begin_example > ob-fortran: Use a defcustom for fortran compiler > > * lisp/ob-fortran.el (org-babel-fortran-compiler): Change `defvar' to `defcustom' > so that the fortran compiler is customizable like almost all other org-babel > compilers. > #+end_example > > This is rather minor though, I mention this mostly as a note for the > future :) Thanks. I went ahead, applied the patch with your recommendation, added a :package-version keyword, and pushed. Thanks. Regards, -- Nicolas Goaziou