From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OO5aJCf6CWFRHAAAgWs5BA (envelope-from ) for ; Wed, 04 Aug 2021 04:23:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8F/lHyf6CWHlUQAAbx9fmQ (envelope-from ) for ; Wed, 04 Aug 2021 02:23:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBEB579F0 for ; Wed, 4 Aug 2021 04:23:34 +0200 (CEST) Received: from localhost ([::1]:53882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mB6ZA-00086q-KT for larch@yhetil.org; Tue, 03 Aug 2021 22:23:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mB6Yi-00085J-OA for emacs-orgmode@gnu.org; Tue, 03 Aug 2021 22:23:04 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:43884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mB6Yg-0005lh-O4 for emacs-orgmode@gnu.org; Tue, 03 Aug 2021 22:23:04 -0400 Received: by mail-pj1-x1036.google.com with SMTP id pj14-20020a17090b4f4eb029017786cf98f9so1514524pjb.2 for ; Tue, 03 Aug 2021 19:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=+xq0SV3izxvRPHjpW2R+f/mbJ9ul4JOmPSDxq2Rc/G8=; b=tRRFlUxTGb6xWNC3cADTq9mcu8vDwgpOOw7dkV4A/PtiH+CSyaxF+P82sNGE8h75N/ RmVEsI8CO01FiERj9WTBKkLYhQ3OdjqEF1XdzD1XACn2H61jW7jcmxehbKmMPILVefKx vfBPBkv9liJiLlQ2Ksj8ZP+EormIFt0IC2fOsu9uFGM9bFWuhFwk5L0RzuWCqO4ZrVvU vN2hNbUHcISDSuRXb2HT6HGe83nWtMbCP1aTnFPiA+vVjZIZ3nFvAogiSobszBuuHOO1 2mPk54Tp5fJyFtg0zHLzrLE9Li5olMgKFKoGW+N4PkcpCU02vgfGL5TvD7DKa4bWT+pF VftQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=+xq0SV3izxvRPHjpW2R+f/mbJ9ul4JOmPSDxq2Rc/G8=; b=NYdtPADnk0KxSIQiaKHUnDIVYRb8Pw5Swah/Yv11DRUKKY4PuOc0BYSrEQWlNCVbMm 9d0NrtV8+GTb0NAWJhi+cw5eiqzo7/GxD6ElLTtB7HBTAqQ0aGNFoAjkKP4SbC2KVWoz WIh88S5GME50AtjTOj5bHR86Ir/ZaAwQOZfI5m3QdFp8ungoT2S8meYBYGgbkWwZuJtZ q4jOlHR3XSm3qT0taYsrpUW2M8P5pH1i4xFHw7Fg7l4OU5OeYF+II/14X7EP2KTq0a1i Q3cRY6QR/cPqMFvJMZHXzpKvagUBW92Ou4yOQ9Rz3hPsQTf8Ld06oMyb7WctBBNFZ0rb +FOw== X-Gm-Message-State: AOAM532HE6KqYFGsTpWUMsQYJ44/9bEU/yDjz6lSR2cxyA0Gm9lXZ5L1 46UoJaHfRPe6Aq0satNUhXofZPgtVOA= X-Google-Smtp-Source: ABdhPJwBrrpFA1951vPPWIiArAyAxRSaYhVtAkVhBtu9yTqkRhGbgotNn4ZWp6Hn4ADIe/8KgfjixQ== X-Received: by 2002:a17:902:e141:b029:12c:68bb:8ea3 with SMTP id d1-20020a170902e141b029012c68bb8ea3mr20933189pla.78.1628043780804; Tue, 03 Aug 2021 19:23:00 -0700 (PDT) Received: from tim-desktop (106-69-86-239.dyn.iinet.net.au. [106.69.86.239]) by smtp.gmail.com with ESMTPSA id n1sm555916pgt.63.2021.08.03.19.22.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Aug 2021 19:23:00 -0700 (PDT) References: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> User-agent: mu4e 1.6.1; emacs 28.0.50 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: Bug: org-agenda-highlight-todo: =?utf-8?Q?Symbol=E2=80=99s?= function definition is void: string-empty-p [9.4.6 (9.4.6-11-g1ee52c-elpa @ /home/vmg/.emacs.d/elpa/org-20210726/)] Date: Wed, 04 Aug 2021 11:41:43 +1000 In-reply-to: <09a29a60-b254-9207-0d44-eaf0b1ba964b@ya.ru> Message-ID: <87im0mq77j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::1036; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1036.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628043815; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=+xq0SV3izxvRPHjpW2R+f/mbJ9ul4JOmPSDxq2Rc/G8=; b=aTnLACxe6fJLxU+tSppneTRI3LGokI9/gde2QZYrQUiO3I9TmCtGK9l60/rh79s5hEZemQ 8OEAESsychRQVJJgxZnBN1zuem4sCwHCjWwHpnVhWhofz50Vb5S8xm4HhBaXCQQ1URMAkq LYOI1yjRTG/DUWc3roOJosoVYEbxrc+Qy1hPG9n2L+gINry4JGovLdVeInheC/IDXnCKvk b26FgiI8xSMAqe35213GCoxJjyMx+N+NeuWftZTezgfWX4981a/Ox1YobhbCDTEq2xJ/O8 MsI3jqfGl2lKwagckI4Zzm51iiBU1+w3wtXW5/I1UzpDqRLuyD6RfglGK24qNg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628043815; a=rsa-sha256; cv=none; b=mlIw0xyvQk4a1x3pOgicJkbLRbe7tv4KJ5Q6KXVxepQihWQ00LBIMbJGT+aJFWRbAsbLzs XbAM2JrPOKon9gleLuV5Z5j/Lqi5hHaWha14Rg4VZGxokd0cY+6plfOys8DavaX//ggOUV rj3aZnt9NMkGb0S1zcNg3jIUTEP71yMAydfAtDdCMJKIMQWsjW8HdOeBQYJxOaIZG4W9br s8Db7xcmreZ66z7iX3FCSWm/0/3YIYz2NgbmwKcqFMFf6rMw8t/Y9zL99n5eQIjn2p0rWV GwKtgenN6agGp03sxCmJ6ELCSmeYwlm+PqzinoEwRfT31M4+74lZeDGYFoLLfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tRRFlUxT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=tRRFlUxT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: CBEB579F0 X-Spam-Score: -3.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: PT7xd133uuAF =D0=92=D1=8F=D1=87=D0=B5=D1=81=D0=BB=D0=B0=D0=B2 =D0=93=D1=80=D0=B8=D1=88= =D0=B8=D0=BD writes: > Remember to cover the basics, that is, what you expected to happen and > what in fact did happen. You don't know how to make a good report? See > > https://orgmode.org/manual/Feedback.html#Feedback > > Your bug report will be posted to the Org mailing list. > ------------------------------------------------------------------------ > > 1. > > I updated orgmode package and trying to org-agenda-list, as usual. But f= ailed with mistake =E2=80=94 org-agenda-list was empty. > After investigation, I took advice to put this: > > ;; NB If you want to use this library, it's almost always correct to use: > (eval-when-compile (require 'subr-x)) > > in the beginning of .emacs. And it worked. Org-agenda-list was fine. I suspect that adding that line has actually hidden a larger problem. The above line is essentially telling emacs to load the subr-x package when your compiling an emacs-lisp file. However, your not compiling your .emacs file, so this will not have any effect unless your compiling your .emacs file. It is rarely worthwhile compiling your init file. Far better off to keep your init file relatively small and pushing complex/large configuration stuff into separate files which can be compiled. There are a number of complications you often need to deal with when compiling your init file and dealing with these often adds enough complexity to outweigh the any benefits to startup time, which are typically very small anyway.=20=20 The symptoms you are seeing are frequently seen with a broken org install. This can easily happen if you attempt to upgrade org when you already have org functions loaded. Basic problem is that you end up with a broken mixed installation with parts from the old version and parts from the upgraded version. Note that if the issue was as you described, many people would be experiencing this bug, but they aren't. This suggests the problem is local to your setup.=20=20 I would remove the upgraded org package and try re-installing. However, it is really important to make sure your .emacs does not call any org functions because this will load org during startup and then when you attempt to upgrade the package, you will get the same issue. This may require some re-organisation of your .emacs file - possibly wrapping org related code in an eval-after-load or using something like use-package etc. An easy way to verify which avoids large refactoring of your init file would be to comment out any org related configuration from your init file, restart emacs. upgrade org, uncomment what you commented and then restart emacs.=20 > > The org-agenda-highlight-todo function (org-agenda.el file) uses the > string-empty-p function from the emacs-lisp/subr-x.el module, but > somewhere is not done (require ' subr-x), so when calling the > org-agenda-highlight-todo function, string-empty-p is not defined, > which leads to an error =E2=80=94 org-agenda-highlight-todo: Symbol=E2= =80=99s function > definition is void: string-empty-p > > 2. > > For checking I called the emacs -Q and put in it scratch: > (string-empty-p "test") > (require 'subr-x) > Then I executed the command > C-x C-e > on > (require 'subr-x) > output was > Debugger entered--Lisp error: (void-function string-empty-p) > (string-empty-p "test") When you did C-x C-e, either you evaluated the first sexp or it tried to evaluate all sexps in the scratch buffer, calling string-empty-p first and before require 'subr-x, so the library was not yet loaded and the function was not found. the require needs to be before functions from the required library are called.=20