From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJiSOwI/mmGfPgAAgWs5BA (envelope-from ) for ; Sun, 21 Nov 2021 13:43:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OBQ2NwI/mmHUSgAAB5/wlQ (envelope-from ) for ; Sun, 21 Nov 2021 12:43:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5ED29FC96 for ; Sun, 21 Nov 2021 13:43:46 +0100 (CET) Received: from localhost ([::1]:48796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1momC7-0007Af-Ps for larch@yhetil.org; Sun, 21 Nov 2021 07:43:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1momAP-0007AW-8u for emacs-orgmode@gnu.org; Sun, 21 Nov 2021 07:41:57 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1momAM-0000G7-RW for emacs-orgmode@gnu.org; Sun, 21 Nov 2021 07:41:56 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 1D189E0006; Sun, 21 Nov 2021 12:41:50 +0000 (UTC) From: Nicolas Goaziou To: Jonas Bernoulli Subject: Re: Merging ox-texinfo+ into ox-texinfo References: <87ilx19pjh.fsf@bernoul.li> <87v90o2tz8.fsf@nicolasgoaziou.fr> <8735nq4jwd.fsf@bernoul.li> Date: Sun, 21 Nov 2021 13:41:50 +0100 In-Reply-To: <8735nq4jwd.fsf@bernoul.li> (Jonas Bernoulli's message of "Sat, 20 Nov 2021 22:06:10 +0100") Message-ID: <87ilwlwui9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637498626; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=eJT8vUUHQKW0hU4a1Yiwq3E+E3Ie9oKcop8kictevhI=; b=L04Cz7pfT4gmSbJz/hkPELZ2R5d+u4ROtoEHy7SjDGL+EEtpX9W5z/LQ0EftaNqiSAGeoi fQZyEcsmW1lIaYD5ubJ+RkOJ4xcMN7qiVfcv7STP6V27X0G6NVxAIeL+P/sF1/7ZN7Wb5n LOXf5UUQXdBWLZjepBeQghPgiAJGxLwIaKsu3SF0P8xDMFiMBqwcptItZUcU81EE+4w6kZ 5xCt7AOiR5NS/5wZHGGFQnr3OM/olmDQBMfvpVMDx0j4uEsS8rGopREfvRvtyYT4Lbf1Tt uOWB+peC2B9bc1exT2OL6WPXyzJ8rVLJZ9V3HUfqgwyeLsOLhEFMO3iyH+2txg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637498626; a=rsa-sha256; cv=none; b=K3U1EH5RAxjOVV+Te/Yjb2ctQry1Z4hd+SKXT1Prlv1wRKtbypN9fZ70OW1IT5a1+6oqHK IjotU6s+vlyE+cUDlDzjQzVqllH6481tqi5Pq2wwN1jEXUoXDbREhoGToMREosdk4hPf0x JAL+kDR2LAioMIGAjsrlV4TTCDuMrHyMpAr9gzl9211kT8Oe6lhqXZwP9I1v7KAhgocUUW l2P80fbm9lwwEp3Q9R8jPRMt1Wsn19fabNa+xWFByty18O4fpOl+AmbXD24dAIndKp4Azf 4sApH8YA/ZLgzqC/A8kmoxP93bzihb5N80w/la5IF+r9GWnWsVmrbyjW+N6hcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.98 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 5ED29FC96 X-Spam-Score: -2.98 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4C7gQx2Aw56v Hello, Jonas Bernoulli writes: > Of course. I probably used the separate keyword because all the entries > for ox-texinfo's :options-alist did that too, but if that's not how this > is usually done for booleans, then I see no reason not to change it. More precisely, there's an historical distinction between string values and other values (symbols, numbers...). The former is set by keywords, the latter is obtained with "options". Consequently, all the entries in ox-texinfo's :options-alist are used to set strings. > Well... it turned out not to be true, but I should be able to get it to > work. The idea is that the new shorthand handling is only used if such > a shorthand is actually used by the item that is being processed. All > other list items should effectively be treated as before, but that isn't > the case yet. For now all non-shorthand list items are simply treated > as @item, but `org-texinfo+-item' could be changed to instead fall back > to the `org-texinfo-item's default behavior in those cases. (It would > still have to check whether it needs to begin and/or end the "item > container" (itemize/table/...), so it is not completely trivial, but > should be doable.) Then I suggest to use "attr_texinfo" keyword, for example: #+attr_texinfo: :shorthand t - item... This way, we ensure the change is local. `org-texinfo-item' already checks :sep attribute. In this case, there's no need to add a new keyword or extend "options". > So I have to address the above issue and then we also have to think > about naming. I was thinking about using the term "shorthands"; instead > of "texinfo-deffn:t" we could use "texinfo-shorthands:t". The functions > need to be renamed too of course, but IMO simply replacing "ox-texinfo+" > with "ox-texinfo-shorthand" is quite ugly. Do you have a suggestion for > that? All the new functions could be placed in the "Item" section. I see no reason to change the prefix, since these functions are part of ox-texinfo. I didn't look closely at your code, tho, so I may be wide of the mark. WDYT? Regards, -- Nicolas Goaziou