[BUG] inserting notes at end

[BUG] inserting notes at end

[Tor Kringeland]

If our Org file is

#+begin_example
* a heading

text<POINT>
#+end_example

And we insert an empty note, we get

#+begin_example
* a heading

- Note taken on [2022-07-26 Tue 16:10]
text
#+end_example

instead of the expected

#+begin_example
* a heading
- Note taken on [2022-07-26 Tue 16:10]

text
#+end_example

If POINT is at the heading or the line below, behavior is as expected.
If a note has already been inserted correctly before (as in the third
snippet), then subsequent notes are insert corrected as well, regardless
of POINT.  Conversely, if one first is inserted wrongly, then subsequent
will also be inserted wrongly.

Re: [BUG] inserting notes at end

[Ihor Radchenko]

Tor Kringeland <tor.kringeland@ntnu.no> writes:

> If our Org file is
>
> #+begin_example
> * a heading
>
> text<POINT>
> #+end_example
>
> And we insert an empty note, we get
>
> #+begin_example
> * a heading
>
> - Note taken on [2022-07-26 Tue 16:10]
> text
> #+end_example
>
> instead of the expected
>
> #+begin_example
> * a heading
> - Note taken on [2022-07-26 Tue 16:10]
>
> text
> #+end_example

I get note after empty lines below the headline in both the cases.
This behavior is intentional according to org-log-beginning.

Best,
Ihor

Re: [BUG] inserting notes at end

[Tor Kringeland]

Ihor Radchenko <yantar92@gmail.com> writes:

> I get note after empty lines below the headline in both the cases.
> This behavior is intentional according to org-log-beginning.

I see.  Maybe this could be noted in the docstring for org-add-note?  If
org-log-into-drawer is non-nil, then the behavior is different (the
drawer is always placed at the first newline below the heading).

Re: [BUG] inserting notes at end

[Ihor Radchenko]

Tor Kringeland <tor.kringeland@ntnu.no> writes:

> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> I get note after empty lines below the headline in both the cases.
>> This behavior is intentional according to org-log-beginning.
>
> I see.  Maybe this could be noted in the docstring for org-add-note?  If
> org-log-into-drawer is non-nil, then the behavior is different (the
> drawer is always placed at the first newline below the heading).

The reason why empty lines are skipped when inserting the first note in
a headline is purely technical. It may or may not be changed in future.
The behaviour is essentially undefined - there is not much point
"freezing" the current behaviour in the docstring.

IMHO, there is not much point changing the current behaviour to not
skipping empty lines. I personally prefer to keep empty lines after the
headline and before notes. So, opinions can differ.

A proper implementation that would satisfy all users should do something
similar to :empty-lines in org-capture-templates, but it will be a fair
bit of work with no clear interest from Org users. Of course, if anyone
thinks that such feature is going to be useful, please chime in and reply
to this email.

Best,
Ihor