From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +PtiFwHbIWOesQAAbAwnHQ (envelope-from ) for ; Wed, 14 Sep 2022 15:45:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AIC0FgHbIWNC2QAAG6o9tA (envelope-from ) for ; Wed, 14 Sep 2022 15:45:37 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE65C28F04 for ; Wed, 14 Sep 2022 15:45:36 +0200 (CEST) Received: from localhost ([::1]:56918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYShr-0006LN-LO for larch@yhetil.org; Wed, 14 Sep 2022 09:45:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYRYh-0006CJ-FP for emacs-orgmode@gnu.org; Wed, 14 Sep 2022 08:32:08 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:37828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYRYf-0008I7-B6 for emacs-orgmode@gnu.org; Wed, 14 Sep 2022 08:32:02 -0400 Received: by mail-pf1-x433.google.com with SMTP id a80so6187914pfa.4 for ; Wed, 14 Sep 2022 05:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=2VnFHGBnvRMFkq/sqMKq7JMk3BVMCURl0EdMWo12WZ0=; b=NetrL5gBRyfm4wj3Xc1UAcTE6lCu526W+aFsLt7HzyMALqzHfKXq5txL91aN1Fal28 xTr1I+m1+XO+tuGECB1gRxQYMzhejSolTZRbfAE8XyVNKpAF07HcfRunE+4IakH3WTh2 h4oS4AzgjWf4dWq2OSmR6djbwS+hEJWJCk2fgjZ9gTc2SRUkl8A6/IoeEqFIt4XCdaY8 63d0rYTzNy7jZLpqaMXbQvEI39ZZT3yj3gVJQMgfMG3C0bvqX8WgdCkw2xblZWAjDyHb 6vfwErvDxXBbYuocXgN3MvbYKjXaG5hrbTzgBsJ5nXH02XuTHuGCYj1n9P0HGIjULAOM +CUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=2VnFHGBnvRMFkq/sqMKq7JMk3BVMCURl0EdMWo12WZ0=; b=M0c74iXpWw7Av19iSl6bMSuAIXVCNEUT1mYnLq6rKbdNby0snaxGSkdx6+Zr5395YB F2qcNHNPjiPwwxLShC4HLZFvwx1OLyBu15gdwebvDAZPwv+1JXqqH5GwVt+QwQw1eOoX rwHBcb7kSkT8gOQBcFtS7vffZQ3HIARGEwYeyILowj50oxitd5051lWkQiB/QAYALtH9 31v1CQ6fBZde228Qs9rieeBU7UJMlGFpo6EZJQzHNtMXCLwK86GKQl6LCoGKbP5EwAJn ozeot3DlK1yD9ZccCp/rLGXlHOKIvD9Pdp81bGZw/US0R7pN3mj0/UJn6kGY0yislPW+ xeaA== X-Gm-Message-State: ACgBeo3opVgqervR5YCecATBKBLi1DI8Itg1akMjk9CewC9zLRDbJUJW /HsFBxKsqTEIiKTAwg/rjFI= X-Google-Smtp-Source: AA6agR6efZ85CiMJWHfoIg/cKabC3cCPIpDlLRm0/11QpXF4pkcteLkhBWSivV2UpcQ7iq79myFMag== X-Received: by 2002:a63:f918:0:b0:438:766e:e57a with SMTP id h24-20020a63f918000000b00438766ee57amr23681823pgi.584.1663158719623; Wed, 14 Sep 2022 05:31:59 -0700 (PDT) Received: from localhost ([2409:8a70:2bc:c850:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id l22-20020a17090af8d600b002031264a864sm1571445pjd.41.2022.09.14.05.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 05:31:58 -0700 (PDT) From: Ihor Radchenko To: Stefan Monnier Cc: emacs-orgmode@gnu.org Subject: Re: Use lexical-scoping in tests In-Reply-To: References: Date: Wed, 14 Sep 2022 20:32:53 +0800 Message-ID: <87illqxhje.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=yantar92@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663163137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2VnFHGBnvRMFkq/sqMKq7JMk3BVMCURl0EdMWo12WZ0=; b=AvjsQ1xeTz358pxflV61WcvYgX+kmdJG+iqYL9bWoEhv2cxUa4nzG2aM1SOIDZha9Ir8tF icDVy4QGXkyTC1LCV+76LLV+oUiijMa1HhxnhrdJCwMV1Xx3wGoJ/8VwRTjiLJ9jP2A2Bl RSLa10EvJT7/wQL/eBqiON7VzGvqMcqaLu0LAYmqhzhPCau6q81YMVGDo/EhHcxvj7IcuE b/aD6AeIV57v3Y+X7aD6rt1okqdS3LMmlYNA/UaY+W6LVlEvv8tbQVLNVet/aZ1O6TH0IZ jJhSJ+E1r8rYU/pPChQjrUKq2E/GJrE7sJAYQrUaBHcK3b41yrzxSloX3GG/AA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663163137; a=rsa-sha256; cv=none; b=AvgUNW3tqx7V5dnnehqx2PwLGzgbugMY9NHVtRf2/qzEQiWXEByEHz8RgU6ywb9ldOnw8h LePMdW1gSwjqCriE/GatbAj4juPiMUWarqDtuB/I0ojYkGNxDHlQk14/SEsmC6VWDxGrq/ VFMby5lMi90y6cTw6qGhwdUAdzh5emfaRd1RWKr7MKGzvTVwp7kjRAyop6WtMeIU4LXiZP 7bCXSrYNAuffmA3ldmESyvvLq1eotIxjje+EDq2xHFKlcLNPLtGOoV8Vo4eIS8o4xiqXXq p79T000RzH3HH95rapaHAS0tnxuDhR12pOmZgD9Ff2Au8NzZj6dKk3lANuSE+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NetrL5gB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=NetrL5gB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DE65C28F04 X-Spam-Score: -7.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: ItV0jCfU/+0y Stefan Monnier writes: > The patch below simply enables `lexical-binding` in all the test files. > As far as I can tell, it's all that's needed (beside a missing > `require`). Thanks, but the patch causes 23 tests to fail (running make test). Also, is there any reason why it was a plain diff? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92