From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OB06AkyhP2MgZwAAbAwnHQ (envelope-from ) for ; Fri, 07 Oct 2022 05:47:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mBM5AkyhP2PiSwEAauVa8A (envelope-from ) for ; Fri, 07 Oct 2022 05:47:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9298019F64 for ; Fri, 7 Oct 2022 05:47:22 +0200 (CEST) Received: from localhost ([::1]:55708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogeKW-0003KC-Li for larch@yhetil.org; Thu, 06 Oct 2022 23:47:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogeJr-0003Jh-TW for emacs-orgmode@gnu.org; Thu, 06 Oct 2022 23:46:40 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:43581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogeJq-0004YQ-0f; Thu, 06 Oct 2022 23:46:39 -0400 Received: by mail-pg1-x52b.google.com with SMTP id a23so3532967pgi.10; Thu, 06 Oct 2022 20:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=Jq/XQA8TA4Dqi6oBJn3DxCuXHonrlEC+hdEeWRaKsZk=; b=V2RINZnAe7B2qrJOX/r/2Pu77AzfuYdNiYPKZcQBC5IlwPn9rKeSQ1aapGWyB0p0MY crkvH+6+KFZP/zNizZqofeGsOZIr93XRJvg1GtF2niq7puTvsHG5RUznEp1crX6uBnLj W4/iHcP5rseYRBIHrUq/8IdokPsAnU05QUFzYbRltNguLdrrvvVJ08kaOtka5MduYIWO yJmFAQ8Y2FgAne8hCQObmmyHShBa7Olpbqbx1jfL912GhO5X1BrwMzVRWdKbFd5EvaCE NQ5G8ygOLcCom4pe8mzY2ad0Wv8MBlj4FguniP9USRWzd5zBKJX/HexprGKYzT1FG/cZ Bq5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=Jq/XQA8TA4Dqi6oBJn3DxCuXHonrlEC+hdEeWRaKsZk=; b=B+yjMwejVwh+bJymFmk54N59RabOF35CitjNgIX/C7GebprGcY31GJP3lPcONkxpgh zxiUdbkdC1ddOC0xyJjBzctCgdLnjfA+Lqhqt8jSN0r9QLZxPx8CunUofRKbXS1Uyr4Q Q1fQGPoAaxVTXBXTqNMyjFmwJ5uu9Mv2x+NTUmOPCN7s3Iu8Bess6v/67US4GuLgNlk4 bUVZGxx0auIy5WZmTrCQoPaG/cL/MPAdbShGwoR43cjOmVWBC42lLzXZWf7iWsqkNEL+ Lax36rRloMmEnwp09TeI3Z7GMiIPzPZbRzHCfgv3Qt1Rnrz5B9gDeM1y3iPTrJiqAoly j5qA== X-Gm-Message-State: ACrzQf0aZfh6FkbKtclfJE8U9Ia0yQLgD0qNu+ojO+2z0lraBXMAYE0v X/BFrhoBMXKJ8ebmS7g6J+oE6gfhzkgQT1Z8 X-Google-Smtp-Source: AMsMyM5TeXzkiFNwpckIqzjzc5XSKkfqAl2KisQ6R+Aeg5fNvWkRY6mOTzDOKXMaVYaGwWjpyAJpaA== X-Received: by 2002:a05:6a00:2402:b0:52c:81cf:8df2 with SMTP id z2-20020a056a00240200b0052c81cf8df2mr2977907pfh.40.1665114388902; Thu, 06 Oct 2022 20:46:28 -0700 (PDT) Received: from localhost ([2409:8970:af2:32f:6c23:3ad5:f37d:541b]) by smtp.gmail.com with ESMTPSA id e188-20020a621ec5000000b005622f99579esm414390pfe.160.2022.10.06.20.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 20:46:28 -0700 (PDT) From: Ihor Radchenko To: Liu Hui Cc: Bastien , emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky agenda In-Reply-To: <87tu4hk491.fsf@gmail.com> References: <87edvochb7.fsf@gmail.com> <874jwjasv3.fsf@localhost> <87tu4hk491.fsf@gmail.com> Date: Fri, 07 Oct 2022 11:47:18 +0800 Message-ID: <87ilkw1eih.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665114442; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jq/XQA8TA4Dqi6oBJn3DxCuXHonrlEC+hdEeWRaKsZk=; b=j2/XXweskPh988PgxL29YzYEefMyD+L/YPP2TL7ijF7VqQxDdnf2aWYpVWSNZjA6tEOcBr oSnNr7ywO4IjeY33NtZsdkyA0gwZSPesk87rPQla7GOgpxPHhLTxfIrRt+wxtCk/gQmboT JlxMrMe4oygW868r8kv4Naj1ErLLkQfVWdLUT/+oot3oT3Wjdyj6zZ21svDULMfLx3aVDk 4szTaoR5rGP9M8v/Wm87JKpxXMFp5EHdqSXvhOre69Ybltd/PWelqxFz+cxKRr4/z/3AUR VNEkJLYODal93PNWg2pWVu+UHvTaJwFCc9t8yXs8Pa4NcW4O9SCNMbrubelZbQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665114442; a=rsa-sha256; cv=none; b=UE7ulpQ9PWILLrN33Vl6uas6duiMsD/50Mk5WaeyRiJPb9o0ZYXMn6b91RTpHBbii67KJ2 +nxaNg7dtRkVikYuPCNBQaNH7QMbRuD7EHFZ6UYymaNK7LAdi0iApoGr6Eebeo0B3NyUO5 gQPtuJDMGAieiwGNn116CtVKxj57KPN/8SgJbYS2OofQKFetsk3TajpeYO4o/GlU/Qx+1v OlAviqWWjYXtVohsGDPiboUqzaQY1QMfyh3Ull1/GTmIxn6wtexkxs6BZmVZlbIwPzHoxl BmNTIN/g77EnHQm6FQGJGOj9KYgtltcjINVNTIicU0yCq9weefFSkhf96a5btA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=V2RINZnA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=V2RINZnA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9298019F64 X-Spam-Score: -1.87 X-Migadu-Scanner: scn0.migadu.com X-TUID: e2byZtuQNmYr Liu Hui writes: > When writing the test, I find the original patch only addresses the > case where an entry contains multiple commands. Now the udpated patch > can address the case containing one command by changing another global > symbol property to per-buffer text property. > > From 718cb5258a407d8a51eb4a5bac3d0c8025a3f198 Mon Sep 17 00:00:00 2001 > From: Liu Hui > Date: Tue, 4 Oct 2022 11:12:41 +0800 > Subject: [PATCH] Fix filter preset problem for sticky agenda Applied onto main with minor amendments (mostly added double space " " between sentences in docstrings and the commit message). https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=edf5afc1d833a814cf97e814194b83b82f26a294 Thanks for your contribution! Also, while we are at it, may you take a look at https://list.orgmode.org/PAXPR06MB7760F3A02D140E7DE2BAAEC6C6F59@PAXPR06MB7760.eurprd06.prod.outlook.com/? AFAIR, it is caused by a similar symbol property approach employed in different place in org-agenda.el. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at