From: Ihor Radchenko <yantar92@posteo.net>
To: emacs-orgmode@gnu.org, ESS-core@r-project.org, lionel.hry@gmail.com
Subject: [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Mon, 17 Apr 2023 18:45:21 +0000 [thread overview]
Message-ID: <87ilduqrem.fsf@localhost> (raw)
Steps to reproduce:
1. cd /path/to/org/git/repo
2. make test EMACS=emacs-27 BTEST_POST="-L /path/to/ESS/lisp -l ob-R -l ess -l ess-r-mode" BTEST_RE="async"
3 unexpected results:
FAILED ob-session-async-R-named-output
FAILED ob-session-async-R-output-drawer
FAILED ob-session-async-R-simple-session-async-output
The tests started failing since 2023/04/04.
https://builds.sr.ht/~bzg/job/968099
I bisected the failure down to the following ESS commit:
536b5b914a75afa37ee05aa8ba0aecd0f9c9eb33
Author: Lionel Henry <lionel.hry@gmail.com>
AuthorDate: Mon Apr 3 13:01:11 2023 +0200
Commit: Lionel Henry <lionel.hry@gmail.com>
CommitDate: Mon Apr 3 13:01:11 2023 +0200
Parent: fef059c3 Wait for process after `ess-r-post-run-hook`
Contained: master
Follows: ESSRv1.8 (21)
Move `ess-r` startup commands out of `ess-r-post-run-hook`
They are blocking commands and the user might have added streaming
commands to the hook.
Also document why users should be careful when mixing blocking and
streaming commands.
------
I am not sure what is going on as ob-R does not really use the changed
hooks. The suspects are
(ess-execute-screen-options t)
(ess-set-working-directory default-directory)))
In particular, I think that `ess-execute-screen-options' is doing
something funny because one of the tests fails with
"1:5" outputting
1 2 3
4 5
split into two lines, which looks like some text filling problem.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next reply other threads:[~2023-04-17 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 18:45 Ihor Radchenko [this message]
2023-04-17 20:26 ` [BUG] ob-R tests fail on Emacs 27 since ESS commit 536b5b914a7 [9.7-pre (release_9.6.4-318-gcfe5e0.dirty @ /home/yantar92/.emacs.d/straight/build/org/)] Lionel Henry
2023-04-18 10:46 ` Ihor Radchenko
2023-04-18 12:30 ` Lionel Henry
2023-04-18 13:11 ` Ihor Radchenko
2023-04-18 13:14 ` Lionel Henry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilduqrem.fsf@localhost \
--to=yantar92@posteo.net \
--cc=ESS-core@r-project.org \
--cc=emacs-orgmode@gnu.org \
--cc=lionel.hry@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).