From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CIpPFNzSY2QIVAAASxT56A (envelope-from ) for ; Tue, 16 May 2023 21:00:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cDFaE9zSY2TxnQAAG6o9tA (envelope-from ) for ; Tue, 16 May 2023 21:00:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1CAE63F5D4 for ; Tue, 16 May 2023 21:00:44 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyztt-0008Pz-P7; Tue, 16 May 2023 14:59:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyztl-0008Nf-Hq for emacs-orgmode@gnu.org; Tue, 16 May 2023 14:59:53 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyzta-0000Fz-TB for emacs-orgmode@gnu.org; Tue, 16 May 2023 14:59:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 26F3C24003C for ; Tue, 16 May 2023 20:59:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684263577; bh=pckcUfiDcxlJB92QdItOe3ePpDG64mR9SzU8KGqgWZE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=CL8JWvY0hC/OllD6TtExDIj/pCzDqR11B2W65y/9oZWpPv+iaM5QTJPcArPcCsNvn L4hvp05i0nAV452FvuKSs/ZSwkz7+qvcoW3Iakth8/O4px1Xg7qMOADr/9kxMRE8GP WuprTsckY6MURis4nMFpfBV/Yhsun8U6rg196cfstNA0JMV0816cpwgqJiXEQolCWk 7WuC7SKGz+N3+fjD/48iG806kABoi1hiNRnpBiThngQU2CwAQvSfpqOCzzuMswpAuI xRgGqOyZ7wbvw2i87hJ6zVmUhXRlf4wWJblC8YXUvJ0KdLotk30El6wJtHhIt+2560 3LxQ9XaLcJtdQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QLQX85MVYz6twn; Tue, 16 May 2023 20:59:36 +0200 (CEST) From: Ihor Radchenko To: Feraidoon Mehri Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org/ol.el: org-link-make-description-function is always applied In-Reply-To: References: Date: Tue, 16 May 2023 19:03:04 +0000 Message-ID: <87ilcs3xqv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684263644; a=rsa-sha256; cv=none; b=BcSvUFc1+gDv8/v+LA6DIqwAW9N0jrCr3H1/sOmT6+7r3reT4NL+44PJc4HUpj4ARCAlcF 8KKHOO+o0IC+BOyOIExBZL7KIA43tLfCHFEXJrIV5SjShwqtA9i0prBvbtUPRjZtwCHGu3 CRFEtBJuLYbD8UMvFnCa+piHwKbuchNynn2c0XH+YxXwgoQCCH82rgxDoH0WvBJK1s4snQ 2FixJthoGp7g1x7YwosE53X9f05KOZzSuJhHPNehJOL3PKqJQkHMGvQvIYPXeTaam9/ecZ UtYi4oKh9XSBTJJzroMhzntFYbHiG/kUJxtXB+NTpTOXJabpRa3i0fK5KFHT6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CL8JWvY0; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684263644; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WKemeZ91jEjaEzaFlhJ+OANdW57eyacXHnBhvcEserw=; b=C+GGZY80NB5Fkmjv+RuGTX+gYeVdvqqQZYHSS+PZp+0vu9Dw+0WaDtaM7nnin/tBBYRcq7 tmJigy+LxSlfMgS40hJJSST/Ml7G1r3glyhf6hOTjirBYdTOqQNP8ctYdDJ1y0JIV46zgY F88XtaQw54JHf+ivcb3GYo8YdPnHFzpdbylNuKQ1lB8Go+tVBMDnILunQqz9bsHc+QBn2J ZFegqOQQpF2AC2YcW0gPhv06QXFe5N/9aGAfT/kENN0ONBlhQ15hxRZqLjfYMjNxC014Kb RjrkVtBge1sX7l5Q9X4RzwC0uYseKRcOhHoIv5lBthu/6XWbYgT75dsGZ5iCuA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=CL8JWvY0; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.17 X-Spam-Score: -6.17 X-Migadu-Queue-Id: 1CAE63F5D4 X-TUID: ZA8wTKIcVgYJ Feraidoon Mehri writes: > The change is very small, so I think taking a look at the diff is more > informative than I trying to explain it; the old code did not use > `org-link-make-description-function` when some other alternatives were > available, but my changes make it always use > `org-link-make-description-function` if set. > > This change is a breaking API change, but I think the previous behavior was > a bug. If you want to preserve the old behavior, perhaps we should add a > new variable `org-link-postprocess-description-function`? The truth is that old behaviour is not fully documented. So, this part of code is extremely fragile. See https://list.orgmode.org/orgmode/87mtb6w2rq.fsf@localhost/ May you go through the `org-insert-link' code and summarize its current behaviour? Then, we can discuss further if and how we want to change it. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at