From: Ihor Radchenko <yantar92@posteo.net>
To: Feraidoon Mehri <feraidoonmehri@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org/ol.el: org-link-make-description-function is always applied
Date: Tue, 16 May 2023 19:03:04 +0000 [thread overview]
Message-ID: <87ilcs3xqv.fsf@localhost> (raw)
In-Reply-To: <CABKKTcgpdEtycrH-SjuT9oFtdVJMKc9vp_fXsgCuntpTEOiArw@mail.gmail.com>
Feraidoon Mehri <feraidoonmehri@gmail.com> writes:
> The change is very small, so I think taking a look at the diff is more
> informative than I trying to explain it; the old code did not use
> `org-link-make-description-function` when some other alternatives were
> available, but my changes make it always use
> `org-link-make-description-function` if set.
>
> This change is a breaking API change, but I think the previous behavior was
> a bug. If you want to preserve the old behavior, perhaps we should add a
> new variable `org-link-postprocess-description-function`?
The truth is that old behaviour is not fully documented.
So, this part of code is extremely fragile.
See https://list.orgmode.org/orgmode/87mtb6w2rq.fsf@localhost/
May you go through the `org-insert-link' code and summarize its current
behaviour? Then, we can discuss further if and how we want to change it.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-05-16 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 17:25 [PATCH] lisp/org/ol.el: org-link-make-description-function is always applied Feraidoon Mehri
2023-05-16 19:03 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilcs3xqv.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=feraidoonmehri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).