From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Testing: Ensure 'org-id-locations-file' is set before updating
Date: Sun, 13 Aug 2023 08:30:42 +0000 [thread overview]
Message-ID: <87il9jl4y5.fsf@localhost> (raw)
In-Reply-To: <ub84qp$6pu$1@ciao.gmane.io>
Max Nikulin <manikulin@gmail.com> writes:
>> In the absence of clear understanding what went wrong, I cannot accept
>> this patch, unfortunately.
>
> mkdir ~/hide
> mv -i ~/.emacs* ~/hide
> make test-dirty BTEST_RE=test-org-link
>
> Finding ID locations (26/26 files):
> /home/ubuntu/src/org-mode/testing/examples/agenda-file.org
> Opening output file: No such file or directory,
> /home/ubuntu/.emacs.d/.org-id-locations
> make: *** [mk/targets.mk:100: test-dirty] Error 255
>
> I have not looked closely into the proposed patch, but I find it
> reasonable expectation that tests should not write to ~/.emacs.d/
Thanks for the reproducer!
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a0830f94e
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-08-13 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 16:40 [PATCH] Testing: Ensure 'org-id-locations-file' is set before updating Morgan Smith
2023-07-19 8:04 ` Ihor Radchenko
2023-08-12 9:29 ` Ihor Radchenko
2023-08-12 14:26 ` Max Nikulin
2023-08-13 8:30 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il9jl4y5.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).