Re: [PATCH] org.el: Respect org-extend-today-until in timestamps with ++

[Ihor Radchenko <yantar92@posteo.net>]

Valentin Herrmann via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:

> * org.el (org-auto-repeat-maybe): Changed org-auto-repeat-maybe, so that
> switching a repeating todo with a timestamp of the form <… ++…> respects
> `org-extend-today-until'.

Thanks, this would make sense. However, I have comments on your patch.

> -			    (nshift 0))
> +			    (nshift 0)
> +                            (time-to-extend (seconds-to-time (* 3600 org-extend-today-until))))

This will return time since epoch:

(format-time-string "%x %X" (seconds-to-time (* 3600 org-extend-today-until)))
;; => "01/01/1970 06:00:00 AM"

>  			(while (or (= nshift 0)
> -				   (not (time-less-p nil time)))
> +                                   (not (time-less-p nil (time-add time-to-extend time))))

And this compares "now" with year 1970. Will always return nil.

It would make things easier if you added a test for this fix into
`test-org/auto-repeat-maybe' in testing/lisp/test-org.el

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>