From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id IJWiJQALVmWx1wAAG6o9tA:P1 (envelope-from ) for ; Thu, 16 Nov 2023 13:28:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IJWiJQALVmWx1wAAG6o9tA (envelope-from ) for ; Thu, 16 Nov 2023 13:28:48 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51EB71623D for ; Thu, 16 Nov 2023 13:28:48 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="SGvl/62l"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700137728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z5pYvsVRkkedSyQsf4YFV6Yl4M2N71hUqkwklIvKdIM=; b=TpxvwLeZeIpKBu/9xQ1kDnbkpkfYqDwiWbJCnvKs1nJ2jAz1YC+2UNSYLnt/06xCljHHh9 LTMsyeeabvhsV4lBDsf0vMlk6y/dWLzbSsPtvhH+kw+NWcMhgLqw8LGI87tndjuOj7sKze 2n5YfQjKRoPYeB0y/3+IC+53AZmow3JlVuE0FPDBbkGfe8fHa3opfphLJAjeAjP2j9T1Od NEZMEf/lPMc1Ora3CEL92rwCo1xPuxNzR2MxF82BjmH2jtbz8GL0js2ElfZ+tqdL7t07Ut IK5IQZnbrStdYYOwaE71B3+QHkBtNjdiye7j33v6/WwBqMlq/LRiAmrFNhuwQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="SGvl/62l"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700137728; a=rsa-sha256; cv=none; b=uFL3mWZvVHK/Vzm2polrkrjotdJBXMHO/9U7pSWC14tl71L/7H0uZz3pQqSd5XTND9vfHC WjzmETr0RQ/lF5FNBP0BZW6+ZUQfxXupfTsRBBBGy6Vg34LIaKRpP3slRbLbiL5V+gI/Nd j/KlH2MWLBuncFOelSS23jHl8Cbmt+dquvR4MmS7uvSiQtEkcT0UqrN5bn9F6EmIZ3rN7g MjZDNMpYkJLj9I75jC6ICfR9rXKVI6gP4kDClBKCUPgICxZmN75MHyUgZ6T762+tFOMliB cENy1IxRtFNnbqhVyu2KYwhAKcVY89kigf5cFnldVfnR4y9bAGdws1HlHf5n0w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3bTV-0004ou-BE; Thu, 16 Nov 2023 07:28:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3bTP-0004oh-QF for emacs-orgmode@gnu.org; Thu, 16 Nov 2023 07:27:55 -0500 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3bTO-0002jf-C6 for emacs-orgmode@gnu.org; Thu, 16 Nov 2023 07:27:55 -0500 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2c834c52b5aso9503821fa.1 for ; Thu, 16 Nov 2023 04:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700137670; x=1700742470; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=z5pYvsVRkkedSyQsf4YFV6Yl4M2N71hUqkwklIvKdIM=; b=SGvl/62ls+evoMUxPw3DihCaf0Ujh2uwA4w5i75oFzjUOzyERQ1HCnYsw0xSRp0tSe gEY3hE7Q7fZO7A5OL2YOJzGg/W3aWHv/gwrEs2AAbRSAZbx1ePwlpZF/1HKu89QeIfhF kguo6E/UKUDJ1V1OjEdHgPzBnVfnWFeAcgPIZx6sXQaL7nrfqmDF8P6js1WHaqiEKdMA WAgH2K0s0x9ged4q9Y14cu5y5kE1OhPP9perZXRHUKaKgXyV9dlN78qbpUcy2FlJX8XR S2T6ppTuoFV4SxyjFTOw4p/6Gwt4XsqAL++I4hAatvbS7fSd5As/z7+Q/UVuO6oKFQ2S pxrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700137670; x=1700742470; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z5pYvsVRkkedSyQsf4YFV6Yl4M2N71hUqkwklIvKdIM=; b=xQuRB1i3llVO69x7KwCezk+5ryaSFIhS8zwtKYGZUDFs+OIUQIT4hq6QPyO+t9YKFg s60E36+3YY9Sd7snlZNnwQgm0Thxjxl/u6cjaOBXgV5hmBFfj+Sb3KT2IOBSGfFT1W+c 4E6mTI3IlZ0bc83qbM7svVQsRj/lkKyesro9YA6q6bNJ5LyJDY3LSHVF/mFU1lkdIxeU igzUzVGpOj5qNX8UgjpxI5Bmzcv/Zo106Ks+/GKHxKzLeqsLFhME2FAuRRGSdBiYTK/i 6s+RfFSYRljmwKdAenbOMK3BzOre2OlirVY8USuDVQN6dpY/LUCTaAT6eps8+9l21vYZ Wvfw== X-Gm-Message-State: AOJu0Ywv78VqiE1UqgLjm9uGhc+qYX55H4RBRKb07mG19lSsU/W/JV+h 7+D3EH273AIArFMT26j9MsTLdpQFNYLh1Q== X-Google-Smtp-Source: AGHT+IHjgfHnclvQJ/GvU72zEa01NNPIKjM/5WV7vcgOAENM/rIkY4PiEMe+yjBLfsYCPyzWFoMmHA== X-Received: by 2002:a2e:9bcb:0:b0:2c8:323b:9207 with SMTP id w11-20020a2e9bcb000000b002c8323b9207mr6187339ljj.11.1700137669948; Thu, 16 Nov 2023 04:27:49 -0800 (PST) Received: from sonyvaio ([217.71.131.234]) by smtp.gmail.com with ESMTPSA id a16-20020a2e8610000000b002c0055834b3sm1986464lji.4.2023.11.16.04.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 04:27:47 -0800 (PST) From: Ilya Chernyshov To: Ihor Radchenko Cc: emacs-orgmode Subject: Re: [PATCH] testing: Delete duplicate tests In-Reply-To: <87sf5cr7na.fsf@gmail.com> References: <87cz0xndem.fsf@gmail.com> <87cz0wyw9m.fsf@localhost> <87y1ilitzo.fsf@localhost> <87fs3zybvj.fsf@gmail.com> <875y4viv14.fsf@localhost> <878r78ftvs.fsf@localhost> <87sf5cr7na.fsf@gmail.com> Date: Thu, 16 Nov 2023 19:27:44 +0700 Message-ID: <87il61rigv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=ichernyshovvv@gmail.com; helo=mail-lj1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.09 X-Spam-Score: -8.09 X-Migadu-Queue-Id: 51EB71623D X-Migadu-Scanner: mx10.migadu.com X-TUID: YiucQf+zaZnA Ilya Chernyshov writes: > Sure, here it is. In the patch, I added a new file > (testing/lisp/test-deduplicator.el) with a test that checks for > duplicate forms (not just should, should-not, should-error macros) in > all test files. It also makes sense to add a test that searches for completely equal `ert-deftest' definitions and tests with equal bodies, but different names, as you already advised on Matrix. Any other thoughts?