From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug
Date: Wed, 07 Feb 2024 12:27:53 +0000 [thread overview]
Message-ID: <87il305uie.fsf@localhost> (raw)
In-Reply-To: <874jft6vpj.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> Right. This is because after 72c3f5e8e refactoring,
> `org-agenda-skip-scheduled-if-deadline-is-shown' is only respected when
> the deadline is actually shown.
>
> However, judging from the discussion of the original feature request
> (https://list.orgmode.org/CAC10T-n8F+Evxf7vGcMT48R5ovoDy030AV1Cj3XyX02piF0tEQ@mail.gmail.com/T/#u),
> it looks like the purpose of 'repeated-after-deadline value is broader
> than just hiding scheduled record when the deadline record is actually
> in agenda. AFAIU, the purpose is hiding the scheduled information
> completely and unconditionally once the agenda day is beyond the
> deadline.
>
> But then `org-agenda-skip-scheduled-if-deadline-is-shown' does not look
> like the right place for this customization. It would make more sense to
> have a dedicated custom variable for this. WDYT?
No response from Bastien. I am going ahead with introducing a new custom
option. The old option is removed, but remains supported for backwards
compatibility.
Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=b26745b98
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-02-07 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-30 20:45 [PATCH] Fix org-agenda-skip-scheduled-if-deadline-is-shown bug Morgan Smith
2023-12-31 14:32 ` Ihor Radchenko
2024-01-02 20:25 ` Morgan Smith
2024-01-03 15:29 ` Ihor Radchenko
2024-01-03 17:06 ` Morgan Smith
2024-01-04 14:04 ` Ihor Radchenko
2024-01-16 16:45 ` Morgan Smith
2024-01-16 18:52 ` Ihor Radchenko
2024-01-16 20:37 ` Morgan Smith
2024-01-17 13:10 ` Ihor Radchenko
2024-02-07 12:27 ` Ihor Radchenko [this message]
2024-02-07 16:15 ` Bastien Guerry
2024-02-07 16:25 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il305uie.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Morgan.J.Smith@outlook.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).