emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Morgan Willcock <morgan@ice9.digital>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-mode-flyspell-verify: Why skip checking the LOGBOOK?
Date: Sun, 11 Aug 2024 15:33:29 +0000	[thread overview]
Message-ID: <87ikw7jcqe.fsf@localhost> (raw)
In-Reply-To: <875xs8nvnd.fsf@ice9.digital>

Morgan Willcock <morgan@ice9.digital> writes:

> I switch between computers fairly frequently and the Org versions may
> not be exactly in sync.  Rather than editing the source code or
> redefining the entire function, would it be acceptable to you if I use
> the following advice for testing?
>
>   (advice-add 'org-mode-flyspell-verify
>               :around (lambda (orig-fun &rest args)
>                         (let (org-log-into-drawer)
>                           (apply orig-fun args))))

Sure.

>> Ideally, please check things like CLOCK and automatic todo state change
>> notes.
>
> Moving over those entries with the advice added, I cannot see any
> obvious issues, although I imagine some people may see a difference if
> their todo-keywords are spelled in a way that doesn't match the
> dictionary being used by Flyspell, e.g. CANCELED vs. CANCELLED.

Those should not be a big deal - todo keywords are enclosed in
"quotation marks". No worse than any other use of special terms inside
quotes.

Fixed, on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=86abaf6407

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-08-11 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 17:03 org-mode-flyspell-verify: Why skip checking the LOGBOOK? Morgan Willcock
2024-08-10 15:02 ` Ihor Radchenko
2024-08-10 17:19   ` Morgan Willcock
2024-08-11 15:33     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikw7jcqe.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=morgan@ice9.digital \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).